Skip to content

Commit b9a0660

Browse files
committed
review
1 parent 7a025e4 commit b9a0660

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/logger.ts

+3-5
Original file line numberDiff line numberDiff line change
@@ -131,22 +131,20 @@ interface PrefixedLogger extends loglevel.Logger, LoggerWithLogMethod {
131131
function getPrefixedLogger(prefix?: string): PrefixedLogger {
132132
const loggerName = DEFAULT_NAMESPACE + (prefix === undefined ? "" : `-${prefix}`);
133133
const prefixLogger = loglevel.getLogger(loggerName) as PrefixedLogger;
134-
// This is a save cast since export const logger is constructed with getPrefixedLogger
135-
// It is downcastet to `Logger` to minimize the public/exported api.
134+
136135
if (prefixLogger.getChild === undefined) {
137136
// This is a new loglevel Logger which has not been turned into a PrefixedLogger yet.
138137
prefixLogger.prefix = prefix;
139138
prefixLogger.getChild = (childPrefix): Logger => {
140-
const rootLogger = logger as PrefixedLogger;
141139
// create the new child logger
142140
const childLogger = getPrefixedLogger((prefix ?? "") + childPrefix);
143141
// assign the same methodFactory as the root logger.
144142
// this is useful if we add extensions to the root logger that modify
145143
// its methodFactory. (an example extension is: storing each log to a rageshake db)
146-
childLogger.methodFactory = rootLogger.methodFactory;
144+
childLogger.methodFactory = prefixLogger.methodFactory;
147145
// rebuild the child logger with the new methodFactory.
148146
childLogger.rebuild();
149-
return childLogger as Logger;
147+
return childLogger;
150148
};
151149
prefixLogger.setLevel(loglevel.levels.DEBUG, false);
152150
}

0 commit comments

Comments
 (0)