Skip to content

Commit 2581983

Browse files
committed
fix(e2e): without devTools
according to electron-userland/spectron#174 (comment) this might help re error like in https://travis-ci.org/artemv/angular-electron-spectron/builds/500315009 ..but this also could be node version dependent as I don't have it locally on MacOS & Node 9
1 parent 901438a commit 2581983

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

Diff for: e2e/main.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('angular-electron App', function () {
2222

2323
it('creates initial windows', async function () {
2424
const count = await client.getWindowCount();
25-
expect(count).to.equal(2);
25+
expect(count).to.equal(1);
2626
});
2727

2828
});

Diff for: main.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ function createWindow() {
3232
}));
3333
}
3434

35-
win.webContents.openDevTools();
35+
if (serve) {
36+
win.webContents.openDevTools();
37+
}
3638

3739
// Emitted when the window is closed.
3840
win.on('closed', () => {

0 commit comments

Comments
 (0)