Skip to content

Commit c7dbb3f

Browse files
committed
bugfix/ electron builder 22.11 needs Node 14+
1 parent f399d75 commit c7dbb3f

File tree

6 files changed

+121
-74
lines changed

6 files changed

+121
-74
lines changed

Diff for: .github/workflows/macos.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
build:
2020
strategy:
2121
matrix:
22-
node-version: [12.x, 14.x, 15.x]
22+
node-version: [14.x, 15.x, 16.x]
2323

2424
# The type of runner that the job will run on
2525
runs-on: macos-latest

Diff for: .github/workflows/ubuntu.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
build:
2020
strategy:
2121
matrix:
22-
node-version: [12.x, 14.x, 15.x]
22+
node-version: [14.x, 15.x, 16.x]
2323

2424
# The type of runner that the job will run on
2525
runs-on: ubuntu-18.04
@@ -55,7 +55,7 @@ jobs:
5555
uses: GabrielBB/xvfb-action@v1
5656
with:
5757
run: npm test
58-
58+
5959
- name: Run headless e2e test
6060
uses: GabrielBB/xvfb-action@v1
6161
with:

Diff for: .github/workflows/windows.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
build:
2020
strategy:
2121
matrix:
22-
node-version: [12.x, 14.x, 15.x]
22+
node-version: [14.x, 15.x, 16.x]
2323

2424
# The type of runner that the job will run on
2525
runs-on: windows-latest

Diff for: README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ Bootstrap and package your project with Angular 12 and Electron 13 (Typescript +
1818

1919
Currently runs with:
2020

21-
- Angular v12.0.5
22-
- Electron v13.0.1
23-
- Electron Builder v22.10.5
21+
- Angular v12.1.2
22+
- Electron v13.1.7
23+
- Electron Builder v22.11.9
2424

2525
With this sample, you can:
2626

@@ -30,7 +30,7 @@ With this sample, you can:
3030

3131
/!\ Hot reload only pertains to the renderer process. The main electron process is not able to be hot reloaded, only restarted.
3232

33-
/!\ Angular 12.x CLI needs Node 11 or later to work correctly.
33+
/!\ Angular CLI & Electron Builder needs Node 14 or later to work correctly.
3434

3535
## Getting Started
3636

Diff for: package-lock.json

+111-64
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"conventional-changelog-cli": "2.1.1",
7777
"cross-env": "7.0.3",
7878
"electron": "13.1.7",
79-
"electron-builder": "22.11.7",
79+
"electron-builder": "22.11.9",
8080
"electron-reload": "1.5.0",
8181
"eslint": "7.30.0",
8282
"eslint-plugin-import": "2.23.4",
@@ -99,7 +99,7 @@
9999
"webdriver-manager": "12.1.8"
100100
},
101101
"engines": {
102-
"node": ">=12.0.0"
102+
"node": ">=14.0.0"
103103
},
104104
"browserslist": [
105105
"chrome 91"

0 commit comments

Comments
 (0)