zephyr: flash map: fix comparison signedness

rbrscoleman · nordicjm · commit 8b7c7cc91e71 · 2025-03-28T08:43:32.000Z
This resolves a warning when building with `-Wsign-compare`.

`struct flash_area.fa_size` is declared as `size_t` in the Zephyr source
tree (in `include/zephyr/storage/flash_map.h`).

Signed-off-by: Samuel Coleman &lt;samuel.coleman@rbr-global.com&gt;
diff --git a/boot/zephyr/flash_map_extended.c b/boot/zephyr/flash_map_extended.c
@@ -178,7 +178,7 @@ int flash_area_get_sector(const struct flash_area *fap, off_t off,
     struct flash_pages_info fpi;
     int rc;
 
-    if (off >= fap->fa_size) {
+    if (off < 0 || (size_t) off >= fap->fa_size) {
         return -ERANGE;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ int flash_area_get_sector(const struct flash_area *fap, off_t off,`
`178`	`178`	`struct flash_pages_info fpi;`
`179`	`179`	`int rc;`
`180`	`180`
`181`		`- if (off >= fap->fa_size) {`
	`181`	`+ if (off < 0 \|\| (size_t) off >= fap->fa_size) {`
`182`	`182`	`return -ERANGE;`
`183`	`183`	`}`
`184`	`184`