Skip to content

Unable to build nginx with symlinks in some environments #8527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nydr opened this issue Sep 7, 2023 · 1 comment · Fixed by #8523
Closed

Unable to build nginx with symlinks in some environments #8527

nydr opened this issue Sep 7, 2023 · 1 comment · Fixed by #8523
Assignees
Labels
Type: Bug Fix something that isn't working as intended
Milestone

Comments

@nydr
Copy link
Contributor

nydr commented Sep 7, 2023

Error reported in slack.

Describe the bug

When running npm run build-service-images on master, building the nginx container fails with the following error:

Logs

Step 18/20 : RUN bats /app/tests/ssl-install.bats
 ---> Running in 7e09ababbb22
1..7
not ok 1 ssl selection script can run
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 2 if CERTIFICATE_MODE environment variable is not set we return an error message
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 3 Bring your own cert mode but certificates not provided returns an appropriate error message
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 4 Bring your own cert mode with certificates set succeeds
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 5 SSL cert generation works if the CERTIFICATE_MODE is set to SELF_SIGNED
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 6 If self signed certificate exists we do not create a new one
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
not ok 7 SSL certificate auto generation does not generate a new certificate if one exists
# (from function `setup' in test file /app/tests/ssl-install.bats, line 1)
#   `setup() {' failed
# bats_load_safe: Could not find '/app/tests/test_helper/bats-support/load'[.bash]
# /app/tests/ssl-install.bats: line 25: shellmock_clean: command not found
The command '/bin/sh -c bats /app/tests/ssl-install.bats' returned a non-zero code: 1

Environment
Problem has been observed in:
Docker version 24.0.5, build ced0996600
Manjaro, Linux

Additional context

Workaround:
replace symlink with actual folder

rm nginx/tests/test_helper haproxy/tests/test_helper
cp -r scripts/test/bats/test_helper nginx/tests/
cp -r scripts/test/bats/test_helper haproxy/tests/
@nydr nydr added the Type: Bug Fix something that isn't working as intended label Sep 7, 2023
@nydr nydr self-assigned this Sep 7, 2023
@nydr
Copy link
Contributor Author

nydr commented Sep 7, 2023

Issue introduced in #8446

@nydr nydr linked a pull request Sep 8, 2023 that will close this issue
@garethbowen garethbowen added this to the 4.4.0 milestone Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants