Skip to content

Commit eec319d

Browse files
authored
Merge pull request #385 from johndodev/fix-remove
Remove useless serialize on remove
2 parents 80cefbf + 164af5a commit eec319d

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

src/Engine.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,6 @@ public function remove($searchableEntities): array
7272
$data = [];
7373

7474
foreach ($searchableEntities as $entity) {
75-
$searchableArray = $entity->getSearchableArray();
76-
if (0 === \count($searchableArray)) {
77-
continue;
78-
}
7975
$indexUid = $entity->getIndexUid();
8076

8177
if (!isset($data[$indexUid])) {

tests/Integration/EngineTest.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,9 @@ public function testIndexingEmptyEntity(): void
3939
null
4040
);
4141

42-
// Index
43-
$result = $this->engine->index($searchableImage);
44-
$this->assertEmpty($result);
45-
4642
// Remove
4743
$result = $this->engine->remove($searchableImage);
48-
$this->assertEmpty($result);
44+
$this->assertArrayHasKey('sf_phpunit__image', $result);
4945

5046
// Update
5147
$result = $this->engine->index($searchableImage);

0 commit comments

Comments
 (0)