fixed the form authnetication tests

Author: mfaisalkhatri

src/main/java/io/github/mfaisalkhatri/drivers/DriverManager.java

@@ -82,13 +82,7 @@ private static void setupBrowserTimeouts () {
         LOG.info ("Setting Browser Timeouts....");
         getDriver ().manage ()
             .timeouts ()
-            .implicitlyWait (Duration.ofSeconds (20));
-        getDriver ().manage ()
-            .timeouts ()
-            .pageLoadTimeout (Duration.ofSeconds (20));
-        getDriver ().manage ()
-            .timeouts ()
-            .scriptTimeout (Duration.ofSeconds (20));
+            .implicitlyWait (Duration.ofSeconds (30));
     }
 
     private static void setupChromeDriver () {

src/test/java/io/github/mfaisalkhatri/pages/theinternet/FormAuthenticationPage.java

@@ -15,22 +15,32 @@
 
 package io.github.mfaisalkhatri.pages.theinternet;
 
+import static io.github.mfaisalkhatri.drivers.DriverManager.getDriver;
+
+import java.time.Duration;
+
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
-
-import static io.github.mfaisalkhatri.drivers.DriverManager.getDriver;
+import org.openqa.selenium.support.ui.ExpectedConditions;
+import org.openqa.selenium.support.ui.WebDriverWait;
 
 /**
  * Created By Faisal Khatri on 24-12-2021
  */
 public class FormAuthenticationPage {
 
+    private WebDriverWait wait;
+
+    public FormAuthenticationPage () {
+        this.wait = new WebDriverWait (getDriver (), Duration.ofSeconds (30));
+    }
+
     public String getFlashMessage () {
-        return getDriver ().findElement (By.id ("flash"))
-            .getText ();
+        return wait.until (ExpectedConditions.presenceOfElementLocated (By.id ("flash"))).getText ();
     }
 
     public SecurePage login (final String userName, final String password) {
+        getDriver ().navigate ().refresh ();
         userNameField ().click ();
         userNameField ().clear ();
         userNameField ().sendKeys (userName);

src/test/java/io/github/mfaisalkhatri/pages/theinternet/SecurePage.java

@@ -17,17 +17,26 @@
 
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.support.ui.ExpectedConditions;
+import org.openqa.selenium.support.ui.WebDriverWait;
 
 import static io.github.mfaisalkhatri.drivers.DriverManager.getDriver;
 
+import java.time.Duration;
+
 /**
  * Created By Faisal Khatri on 24-12-2021
  */
 public class SecurePage {
 
+    private WebDriverWait wait;
+
+    public SecurePage () {
+        this.wait = new WebDriverWait (getDriver (), Duration.ofSeconds (30));
+    }
+
     public String getFlashMessage () {
-        return getDriver ().findElement (By.id ("flash"))
-            .getText ();
+        return wait.until (ExpectedConditions.presenceOfElementLocated (By.id ("flash"))).getText ();
     }
 
     public String getHeaderText () {

src/test/java/io/github/mfaisalkhatri/tests/theinternet/FormAuthenticationTests.java

@@ -52,13 +52,15 @@ public void testSetup () {
 
     @Test
     public void blankUserAndPasswordTest () {
+
         this.formAuthenticationPage.login (" ", " ");
         assertTrue (this.formAuthenticationPage.getFlashMessage ()
             .contains ("Your username is invalid!"));
     }
 
     @Test
     public void invalidLoginCredentialsTest () {
+
         this.formAuthenticationPage.login (USERNAME, "InvalidPass");
         assertTrue (this.formAuthenticationPage.getFlashMessage ()
             .contains ("Your password is invalid!"));
@@ -69,20 +71,22 @@ public Iterator<Object[]> loginData () {
         final List<Object[]> testData = new ArrayList<> ();
         testData.add (new Object[] { " ", PASSWORD, false });
         testData.add (new Object[] { USERNAME, " ", false });
-        testData.add (new Object[] { " ", " ", false });
         testData.add (new Object[] { USERNAME, "invalid", false });
         testData.add (new Object[] { USERNAME, PASSWORD, true });
         return testData.iterator ();
     }
 
     @Test (dataProvider = "loginData")
     public void loginTests (final String userName, final String password, final boolean isValid) {
+
         this.securePage = this.formAuthenticationPage.login (userName, password);
 
         if (!isValid) {
+            System.out.println (formAuthenticationPage.getFlashMessage ());
             assertTrue (this.formAuthenticationPage.getFlashMessage ()
-                .contains (" is invalid!"));
+                .contains ("is invalid!"));
         } else {
+            System.out.println (securePage.getFlashMessage ());
             assertTrue (this.securePage.getFlashMessage ()
                 .contains ("You logged into a secure area!"));
             assertEquals (this.securePage.getHeaderText (), "Secure Area");

test-suite/testng-theinternet.xml

@@ -58,7 +58,7 @@
             </class>
         </classes>
     </test>
-    <test name="Form Authentication Tests">
+    <test name="Form Authentication Tests - Negative scenarios">
         <parameter name="browser" value="chrome"/>
         <classes>
             <class name="io.github.mfaisalkhatri.tests.theinternet.FormAuthenticationTests">
@@ -67,6 +67,15 @@
                     <include name="passwordNotValidTest"/>
                     <include name="invalidLoginCredentialsTest"/>
                     <include name="blankUserAndPasswordTest"/>
+                </methods>
+            </class>
+        </classes>
+    </test>
+    <test name="Form Authentication Tests - DataProvider">
+        <parameter name="browser" value="chrome"/>
+        <classes>
+            <class name="io.github.mfaisalkhatri.tests.theinternet.FormAuthenticationTests">
+                <methods>
                     <include name="loginTests"/>
                     <include name="loginWithCorrectCredentials"/>
                 </methods>
@@ -113,7 +122,8 @@
             </class>
         </classes>
     </test>
-    <test name="iFrame Tests" enabled="false"> <!--Disabled as the demo web page has errors and does not allow to type in the frame-->
+    <test name="iFrame Tests"
+          enabled="false"> <!--Disabled as the demo web page has errors and does not allow to type in the frame-->
         <parameter name="browser" value="chrome"/>
         <classes>
             <class name="io.github.mfaisalkhatri.tests.theinternet.IFrameTests">