some rules report false positives

[rolandjitsu]

I just discovered some weird cases where angular-whitespace complains about:

• <div fxLayout="column"> (the l - as in the letter L - must be the confusing part)
• <md-icon *ngIf="isOnline | async; else offline">cloud_off</md-icon>
• <md-toolbar color="primary"> - might be the same case as the first one
• <rj-image-filters (queryChange)="updateFilters($event)"></rj-image-filters> - could be the same case with the letter L
• <!-- Setttings --> - might be the ! sign there, nonetheless, comments should be ignored
• <md-select [(ngModel)]="timeRangeKey"> - could be the L again
• *ngIf="query.isUpdating | async as isUpdating" - there's obviously space there, so not sure what the problem is

And banana-in-a-box:

• <a md-list-item (click)="navigate(['/resources'])"> - confuses what's inside the quotes I guess

Finally no-access-missing-member :

• complains about a prop not existing on the class, but it's actually a local var

<rj-paginated-resources *ngIf="query"
							#pagination="rjPagination"
							[type]="type"
							[query]="query | async">
	<div fxLayout="row"
		 fxLayoutWrap
		 class="images"
		 padding>
		<ng-container *ngFor="let image of pagination.items | async; trackBy: trackByImage">
			<div class="image">
				<rj-image-card [image]="image"></rj-image-card>
			</div>
		</ng-container>
	</div>
</rj-paginated-resources>

[wKoza]

Thank you for your issue report. For the last point, there are many issues in the tracker related to template references. For the others, we will investigate.

[wKoza]

Can you give me an example of log for this item : <div fxLayout="column"> ?

Concerning the check-pipe, can you remove it form your configuration for this moment because there is an issue opened (issue #365 ).

[rolandjitsu]

Definitely:

/users/rolandjitsu/projects/test/src/app/test.component.html
ERROR: 4:4    angular-whitespace        The pipe operator should be surrounded by one space on each side, i.e. " | ".

[wKoza]

And if you remove the check-pipe in your lint, what's happening ?

[rolandjitsu]

If I remove that, I get no errors 😄

[wKoza]

Ok nice. You can monitor this issue for resolution. Otherwise, there is indeed a problem with the rule "banana-in-a-box". I will take a look at this weekend.

[rafaelss95]

Maybe it worth to create a new issue for this, but since the title is a bit generic, let's report it here:

Having the following:

@Component({
  ...
  template: `
    <div *ngIf="authService.isLoggedIn()">
     ...
    </div>
  `
})
export class AppComponent {

  constructor(private authService: AuthService) { }

}

Results in:

You can bind only to public class members. "authService" is not a public class member.

[mgechev]

That's the expected behavior from the rule template-use-public.

[mgechev]

Lets reopen the issue since there are problems in other rules (angular-whitespace has some flaws).

[mgechev]

The problem in all rules which involve EmbeddedTemplate is that the syntax is being desugared from:

<li *ngFor="let foo of bar"></li>

to:

<li ngFor let-foo [ngForOf]="bar"></li>

which breaks our mapping. Here's the solution by the language service. It's not straightforward. Most likely I'll reuse it, however, we risk to have frequent breaking changes given the non-stable APIs being used there.

[wKoza]

mmhm, i hope this will be okay ...

[mgechev]

I'm afraid we'll need to keep this. It can be implemented with a strategy, doesn't have to be in a long function but the logic will remain.

[wKoza]

Hi @mgechev, have you progress in this issue ?

[mgechev]

Haven't done anything here yet. The way to go is custom expression parser for *-prefixed attributes.

[wKoza]

ok, I'll look at this If I have time.

[rolandjitsu]

I'm still seeing some problems with the check-pipe rule for:

<p *ngIf="(items | async)?.length as length" class="mat-caption">

<span *ngIf="product.propagationTolerance" class="label">&plusmn; {{ product.propagationTolerance | number }}</span>

For the latter, removing ± seems to fix it.

[mgechev]

@rolandjitsu thanks for pointing this out! I'll move it to a separate issue. Hopefully we'll be able to soon clean the glitches and open a PR to Angular CLI with the new features.