Skip to content

fix(interfaces): mark only the method which corresponds to non-implemented interface #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgechev opened this issue Sep 18, 2016 · 1 comment
Assignees

Comments

@mgechev
Copy link
Owner

mgechev commented Sep 18, 2016

Currently the text editors mark the entire class and it can get quite noisy. It'll be better to mark only the method which requires implementation of an interface, for instance:

@Component({
  // ...
})
export class ZippyComponent {
  ngOnInit() {
    // ...
  }
}

Should mark only the substring:

  ngOnInit() {
    // ...
  }

This requires changes for:

  • useLifeCycleInterfaceRule.
  • usePipeTransformInterfaceRule

And their test files.

@mgechev mgechev added this to the Beta 1 milestone Sep 18, 2016
@preslavsh
Copy link
Collaborator

#92 Updates that

@mgechev mgechev closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants