Skip to content

Commit d55b825

Browse files
committed
test: revert changes to test/parallel/test-cluster-dgram-1.js
We've started to see frequent failures in test/parallel/test-cluster-dgram-1.js on AIX since the refactoring in nodejs#8261. Revert changes until we have time to investigate properly.
1 parent a133b77 commit d55b825

File tree

1 file changed

+21
-18
lines changed

1 file changed

+21
-18
lines changed

test/parallel/test-cluster-dgram-1.js

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
'use strict';
22
const common = require('../common');
3-
const NUM_WORKERS = 4;
4-
const PACKETS_PER_WORKER = 10;
3+
var NUM_WORKERS = 4;
4+
var PACKETS_PER_WORKER = 10;
55

6-
const assert = require('assert');
7-
const cluster = require('cluster');
8-
const dgram = require('dgram');
6+
var assert = require('assert');
7+
var cluster = require('cluster');
8+
var dgram = require('dgram');
99

1010

1111
if (common.isWindows) {
@@ -28,13 +28,13 @@ function master() {
2828
cluster.fork();
2929

3030
// Wait until all workers are listening.
31-
cluster.on('listening', common.mustCall(() => {
31+
cluster.on('listening', function() {
3232
if (++listening < NUM_WORKERS)
3333
return;
3434

3535
// Start sending messages.
36-
const buf = Buffer.from('hello world');
37-
const socket = dgram.createSocket('udp4');
36+
var buf = Buffer.from('hello world');
37+
var socket = dgram.createSocket('udp4');
3838
var sent = 0;
3939
doSend();
4040

@@ -47,28 +47,31 @@ function master() {
4747
if (sent < NUM_WORKERS * PACKETS_PER_WORKER) {
4848
doSend();
4949
} else {
50+
console.log('master sent %d packets', sent);
5051
socket.close();
5152
}
5253
}
53-
}, NUM_WORKERS));
54+
});
5455

5556
// Set up event handlers for every worker. Each worker sends a message when
5657
// it has received the expected number of packets. After that it disconnects.
57-
for (const key in cluster.workers) {
58+
for (var key in cluster.workers) {
5859
if (cluster.workers.hasOwnProperty(key))
5960
setupWorker(cluster.workers[key]);
6061
}
6162

6263
function setupWorker(worker) {
6364
var received = 0;
6465

65-
worker.on('message', common.mustCall((msg) => {
66+
worker.on('message', function(msg) {
6667
received = msg.received;
67-
}));
68+
console.log('worker %d received %d packets', worker.id, received);
69+
});
6870

69-
worker.on('disconnect', common.mustCall(() => {
70-
assert.strictEqual(received, PACKETS_PER_WORKER);
71-
}));
71+
worker.on('disconnect', function() {
72+
assert(received === PACKETS_PER_WORKER);
73+
console.log('worker %d disconnected', worker.id);
74+
});
7275
}
7376
}
7477

@@ -79,15 +82,15 @@ function worker() {
7982
// Create udp socket and start listening.
8083
var socket = dgram.createSocket('udp4');
8184

82-
socket.on('message', common.mustCall((data, info) => {
85+
socket.on('message', function(data, info) {
8386
received++;
8487

8588
// Every 10 messages, notify the master.
86-
if (received === PACKETS_PER_WORKER) {
89+
if (received == PACKETS_PER_WORKER) {
8790
process.send({received: received});
8891
process.disconnect();
8992
}
90-
}, PACKETS_PER_WORKER));
93+
});
9194

9295
socket.bind(common.PORT);
9396
}

0 commit comments

Comments
 (0)