[5.5] Clear CountQuery "select" bindings since we're overriding the columns anyway (laravel#21468)

*    update test

*      handle withCount edge case

*    fix style

*    fix style

Author: themsaid

src/Illuminate/Database/Eloquent/Relations/Relation.php

@@ -188,7 +188,7 @@ public function getRelationExistenceCountQuery(Builder $query, Builder $parentQu
     {
         return $this->getRelationExistenceQuery(
             $query, $parentQuery, new Expression('count(*)')
-        );
+        )->setBindings([], 'select');
     }
 
     /**

tests/Database/DatabaseEloquentHasOneTest.php

@@ -176,7 +176,8 @@ public function testRelationCountQueryCanBeBuilt()
 
         $builder->shouldReceive('select')->once()->with(m::type('Illuminate\Database\Query\Expression'))->andReturnSelf();
         $relation->getParent()->shouldReceive('getTable')->andReturn('table');
-        $builder->shouldReceive('whereColumn')->once()->with('table.id', '=', 'table.foreign_key');
+        $builder->shouldReceive('whereColumn')->once()->with('table.id', '=', 'table.foreign_key')->andReturn($baseQuery);
+        $baseQuery->shouldReceive('setBindings')->once()->with([], 'select');
 
         $relation->getRelationExistenceCountQuery($builder, $builder);
     }

tests/Integration/Database/EloquentWithCountTest.php

@@ -0,0 +1,106 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Database\EloquentWithCountTest;
+
+use Orchestra\Testbench\TestCase;
+use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Eloquent\Model;
+
+/**
+ * @group integration
+ */
+class EloquentWithCountTest extends TestCase
+{
+    protected function getEnvironmentSetUp($app)
+    {
+        $app['config']->set('app.debug', 'true');
+
+        $app['config']->set('database.default', 'testbench');
+
+        $app['config']->set('database.connections.testbench', [
+            'driver' => 'sqlite',
+            'database' => ':memory:',
+            'prefix' => '',
+        ]);
+    }
+
+    public function setUp()
+    {
+        parent::setUp();
+
+        Schema::create('one', function ($table) {
+            $table->increments('id');
+        });
+
+        Schema::create('two', function ($table) {
+            $table->increments('id');
+            $table->integer('one_id');
+        });
+
+        Schema::create('three', function ($table) {
+            $table->increments('id');
+            $table->integer('two_id');
+        });
+    }
+
+    /**
+     * @test
+     */
+    public function it_basic()
+    {
+        $one = Model1::create();
+        $two = $one->twos()->Create();
+        $three = $two->threes()->Create();
+
+        $results = Model1::withCount([
+            'twos' => function ($query) {
+                $query->where('id', '>=', 1);
+            },
+        ]);
+
+        $this->assertEquals([
+            ['id' => 1, 'twos_count' => 1],
+        ], $results->get()->toArray());
+    }
+}
+
+class Model1 extends Model
+{
+    public $table = 'one';
+    public $timestamps = false;
+    protected $guarded = ['id'];
+
+    public function twos()
+    {
+        return $this->hasMany(Model2::class, 'one_id');
+    }
+}
+
+class Model2 extends Model
+{
+    public $table = 'two';
+    public $timestamps = false;
+    protected $guarded = ['id'];
+    protected $withCount = ['threes'];
+
+    public function threes()
+    {
+        return $this->hasMany(Model3::class, 'two_id');
+    }
+}
+
+class Model3 extends Model
+{
+    public $table = 'three';
+    public $timestamps = false;
+    protected $guarded = ['id'];
+
+    protected static function boot()
+    {
+        parent::boot();
+
+        static::addGlobalScope('app', function ($builder) {
+            $builder->where('idz', '>', 0);
+        });
+    }
+}