Add more error mesage parsing #4503
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit a6c04b4. ♻️ This comment has been updated with latest results. |
marrobi
reviewed
Apr 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates error handling by replacing string‐based error message parsing with status-based error detection for improved reliability.
- Update error detection by incorporating deployment or step status checks.
- Refactor components ResourceOperationsList, ResourceOperationStepsList, and ResourceOperationListItem to use the new error status detection.
- Update CHANGELOG.md and increment package version.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/app/src/components/shared/ResourceOperationsList.tsx | Uses deployment status via the imported failedStates to determine error display. |
| ui/app/src/components/shared/ResourceOperationStepsList.tsx | Replaces local error state management with a centralized state to toggle error panel display. |
| ui/app/src/components/shared/ResourceOperationListItem.tsx | Introduces an optional isError prop instead of parsing error messages. |
| ui/app/src/components/shared/ResourceHistoryListItem.tsx | Renames component interface and component but the file name wasn’t updated to match. |
| ui/app/package.json | Bumps version from 0.8.3 to 0.8.4. |
| CHANGELOG.md | Adds a new changelog entry for error message display changes. |
Comments suppressed due to low confidence (1)
ui/app/src/components/shared/ResourceHistoryListItem.tsx:3
- The component is renamed to ResourceOperationListItem, but the file is still named ResourceHistoryListItem.tsx. Consider renaming the file to match the component name for consistency.
interface ResourceOperationListItemProps {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4502
What is being addressed
Change the way we detect whether errors were returned. Instead of parsing the error message we now use the deployment status for enhanced reliability.
How is this addressed