Skip to content

P0784R7 Library Support For More constexpr Containers #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StephanTLavavej opened this issue Sep 6, 2019 · 3 comments · Fixed by #1369
Closed

P0784R7 Library Support For More constexpr Containers #37

StephanTLavavej opened this issue Sep 6, 2019 · 3 comments · Fixed by #1369
Labels
cxx20 C++20 feature fixed Something works now, yay!
Milestone

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Sep 6, 2019

P0784R7 Library Support For More constexpr Containers

LWG-3303 Bad constexpr marker for destroy/destroy_n

Feature-test macro as of WG21-N4842:
#define __cpp_lib_constexpr_dynamic_alloc 201907L

Needed for #43 and #45.

@miscco
Copy link
Contributor

miscco commented Nov 23, 2020

@MichaelRizkalla, I had a look at this because MSVC seems to now support __cpp_constexpr_dynamic_alloc and it is quite difficult to get it right with the huge machinery that std::vector uses

I fixed the merge conflicts and also some broken machinery / test code. You can find the fixes in my P0784R7 branch here https://github.com/miscco/STL/tree/P0784R7

@MichaelRizkalla
Copy link

@miscco, I am still trying to wrap my head around the entire code base and was expecting my PR to be simple to deal with 😿 . Is there any recommendation you see fit to handle this PR given the same content is implemented in your P0784R7 branch?

@miscco
Copy link
Contributor

miscco commented Nov 25, 2020

"My" branch is your branch with merge conflicts resolved and some fixes for MSVC, so you should be able to either cherry-pick, or rebase or reset on that.

Note that i did not fix anything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx20 C++20 feature fixed Something works now, yay!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants