-
Notifications
You must be signed in to change notification settings - Fork 1.5k
vector_algorithms.cpp
: introduce namespaces
#5450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexGuteniev
wants to merge
26
commits into
microsoft:main
Choose a base branch
from
AlexGuteniev:namespaces
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,172
−4,037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b46eae5
to
0d14067
Compare
0d14067
to
9e7aeef
Compare
StephanTLavavej
approved these changes
May 2, 2025
Thanks! I really appreciate the well-structured fine-grained commits, as this would have been impossible to review otherwise. 😻 I pushed a few more commits:
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
added a commit
to StephanTLavavej/STL
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5418
Why namespaces
The goals were:
Both goals are achieved with partial success:
_Find_trats_
orfind
itself, now it happens across namespacesChanges
_Find_traits_
where makes sense_Predicate
using namespace
to make it more clear what is used from_Bitmap_details
_ARM64_EC
and replace byvoid
or completely removeChanges are incremental to enable per-commit review.
(It may be complex to review the whole change, as something is both moved and modified)
Algorithms and namespaces
Namespaces:
bitset
member functions implementations. These were fine, just renamed.minmax_element
,minmax
,is_sorted_until
. These have obvious commonalities, and even referred by the Standard with this name.remove
,unique
,remove_copy
,unique_copy
: They do the same shuffle and share tables for it.mismatch
itself. Originally was among find-like algorithm due to sharing traits. Decided to move out as it does not resemble find, and re-implmenet similar traits separately, which only need some functions from find traits. The use of traits can be completely avoided for this algorithm, but that's another story.count
itself. As originally implemented, it was seen as find-like algorithm, however later it was re-implemented with a dedicated approach. The traits are its own, but still inherit from_Find_traits_
, as all functions from them are needed.find_first_of
andbasic_string
members that match against a set of characters. Pre-existing namespace, but reorganized a bit, in particular, someusing namespace
removed.search
,find_end
, andbasic_string
members members that match subsequence. These are distinct enough from_Find
in that they use SSE4.2 like_Find_meow_of
. They still use_Find_traits_
, but only for fallbacks. Although if there would ever be 32 and 64 bit implementation, it will likely use_Find_traits_
fully.find
,find_last
,adjacent_find
,search_n
, andbasic_string
members members that match one character, including single-chararcterfind_meow_not
. They have also much of commonality.search_n
stands out a bit, but it still uses the same traits, and generally matches a string against a single character, so that is probably fine to keep it here.reverse
,reverse_copy
. The namespace only contains common fallbackThe algorithms that don't have traits or common functions don't need namespaces:
swap_ranges
replace
Though I'm sure it is now better with more structure, I'm not sure in particular namespaces usage.