Skip to content

Commit b67f2d6

Browse files
authored
Remove jake (hopefully for real this time) (#29085)
* Remove jake (hopefully for real this time) * Fix gulpfile non-lkg build, add sanity-check build to posttest on CI, accept older baseline style to go with lkgd build * More docs/scripts jake -> gulp
1 parent 4e3efc2 commit b67f2d6

File tree

12 files changed

+54
-903
lines changed

12 files changed

+54
-903
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Here's a checklist you might find useful.
55
* [ ] There is an associated issue that is labeled
66
'Bug' or 'help wanted' or is in the Community milestone
77
* [ ] Code is up-to-date with the `master` branch
8-
* [ ] You've successfully run `jake runtests` locally
8+
* [ ] You've successfully run `gulp runtests` locally
99
* [ ] You've signed the CLA
1010
* [ ] There are new or updated unit tests validating the change
1111

CONTRIBUTING.md

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ Any changes should be made to [src/lib](https://github.com/Microsoft/TypeScript/
104104
Library files in `built/local/` are updated automatically by running the standard build task:
105105

106106
```sh
107-
jake
107+
gulp
108108
```
109109

110110
The files in `lib/` are used to bootstrap compilation and usually **should not** be updated unless publishing a new version or updating the LKG.
@@ -115,49 +115,49 @@ The files `src/lib/dom.generated.d.ts` and `src/lib/webworker.generated.d.ts` bo
115115

116116
## Running the Tests
117117

118-
To run all tests, invoke the `runtests-parallel` target using jake:
118+
To run all tests, invoke the `runtests-parallel` target using gulp:
119119

120120
```Shell
121-
jake runtests-parallel
121+
gulp runtests-parallel
122122
```
123123

124124
This will run all tests; to run only a specific subset of tests, use:
125125

126126
```Shell
127-
jake runtests tests=<regex>
127+
gulp runtests --tests=<regex>
128128
```
129129

130130
e.g. to run all compiler baseline tests:
131131

132132
```Shell
133-
jake runtests tests=compiler
133+
gulp runtests --tests=compiler
134134
```
135135

136136
or to run a specific test: `tests\cases\compiler\2dArrays.ts`
137137

138138
```Shell
139-
jake runtests tests=2dArrays
139+
gulp runtests --tests=2dArrays
140140
```
141141

142142
## Debugging the tests
143143

144-
To debug the tests, invoke the `runtests-browser` task from jake.
144+
To debug the tests, invoke the `runtests-browser` task from gulp.
145145
You will probably only want to debug one test at a time:
146146

147147
```Shell
148-
jake runtests-browser tests=2dArrays
148+
gulp runtests-browser --tests=2dArrays
149149
```
150150

151151
You can specify which browser to use for debugging. Currently Chrome and IE are supported:
152152

153153
```Shell
154-
jake runtests-browser tests=2dArrays browser=chrome
154+
gulp runtests-browser --tests=2dArrays --browser=chrome
155155
```
156156

157-
You can debug with VS Code or Node instead with `jake runtests inspect=true`:
157+
You can debug with VS Code or Node instead with `gulp runtests --inspect=true`:
158158

159159
```Shell
160-
jake runtests tests=2dArrays inspect=true
160+
gulp runtests --tests=2dArrays --inspect=true
161161
```
162162

163163
## Adding a Test
@@ -197,20 +197,20 @@ Compiler testcases generate baselines that track the emitted `.js`, the errors p
197197
When a change in the baselines is detected, the test will fail. To inspect changes vs the expected baselines, use
198198

199199
```Shell
200-
jake diff
200+
gulp diff
201201
```
202202

203203
After verifying that the changes in the baselines are correct, run
204204

205205
```Shell
206-
jake baseline-accept
206+
gulp baseline-accept
207207
```
208208

209209
to establish the new baselines as the desired behavior. This will change the files in `tests\baselines\reference`, which should be included as part of your commit. It's important to carefully validate changes in the baselines.
210210

211211
## Localization
212212

213213
All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json).
214-
If you make changes to it, run `jake generate-diagnostics` to push them to the `Diagnostic` interface in `diagnosticInformationMap.generated.ts`.
214+
If you make changes to it, run `gulp generate-diagnostics` to push them to the `Diagnostic` interface in `diagnosticInformationMap.generated.ts`.
215215

216216
See [coding guidelines on diagnostic messages](https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines#diagnostic-messages).

Gulpfile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ task("watch-tsserver").flags = {
232232
" --built": "Compile using the built version of the compiler."
233233
}
234234

235-
task("min", series(lkgPreBuild, parallel(buildTsc, buildServer)));
235+
task("min", series(preBuild, parallel(buildTsc, buildServer)));
236236
task("min").description = "Builds only tsc and tsserver";
237237
task("min").flags = {
238238
" --built": "Compile using the built version of the compiler."
@@ -375,7 +375,7 @@ task("lint").flags = {
375375

376376
const buildFoldStart = async () => { if (fold.isTravis()) console.log(fold.start("build")); };
377377
const buildFoldEnd = async () => { if (fold.isTravis()) console.log(fold.end("build")); };
378-
task("local", series(buildFoldStart, lkgPreBuild, parallel(localize, buildTsc, buildServer, buildServices, buildLssl), buildFoldEnd));
378+
task("local", series(buildFoldStart, preBuild, parallel(localize, buildTsc, buildServer, buildServices, buildLssl), buildFoldEnd));
379379
task("local").description = "Builds the full compiler and services";
380380
task("local").flags = {
381381
" --built": "Compile using the built version of the compiler."

0 commit comments

Comments
 (0)