Merge remote-tracking branch 'remotes/origin/main' into fix-55654

Author: dragomirtitian

.dprint.jsonc

@@ -38,6 +38,10 @@
         "yml.singleQuote": true,
         "yaml.singleQuote": true
     },
+    "json": {
+        // This would be good to do in known-JSONC files, but VS Code warns on trailing commas.
+        "trailingCommas": "never"
+    },
     "excludes": [
         "**/node_modules",
         "**/*-lock.json",
@@ -49,9 +53,10 @@
         "**/*.generated.*",
         "scripts/*.d.*"
     ],
+    // Note: if adding new languages, make sure settings.template.json is updated too.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.86.1.wasm",
-        "https://plugins.dprint.dev/prettier-0.27.0.json@3557a62b4507c55a47d8cde0683195b14d13c41dda66d0f0b0e111aed107e2fe",
-        "https://plugins.dprint.dev/json-0.17.4.wasm"
+        "https://plugins.dprint.dev/typescript-0.88.3.wasm",
+        "https://plugins.dprint.dev/json-0.19.0.wasm",
+        "https://plugins.dprint.dev/prettier-0.27.0.json@3557a62b4507c55a47d8cde0683195b14d13c41dda66d0f0b0e111aed107e2fe"
     ]
 }

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -13,8 +13,7 @@ body:
 
         List them here so people in the future can find this one more easily.
       placeholder: |
-        List of keywords you searched for before creating this issue.
-        Write them down here so that others can find this bug more easily and help provide feedback.
+        List of keywords you searched for before creating this issue. Write them down here so that others can find this bug more easily and help provide feedback.
 
         e.g. "function inference any", "jsx attribute spread", "move to file duplicate imports", "discriminated union inference", "ts2822"
     validations:
@@ -26,21 +25,19 @@ body:
       description: |
         When did you start seeing this bug occur?
 
-        "Bugs" that have existed in TS for a long time are very likely to be FAQs; refer to
-        https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs
+        "Bugs" that have existed in TS for a long time are very likely to be FAQs; please refer to the [FAQ wiki page](https://github.com/Microsoft/TypeScript/wiki/FAQ#common-bugs-that-arent-bugs).
 
+        Please try the nightly version of TS to see if it's already been fixed. Install `typescript@next` or use the [Playground](http://www.typescriptlang.org/play/?ts=Nightly).
 
-        If possible, please try testing the nightly version of TS to see if it's already been fixed. For npm: `typescript@next`
+        If possible, try bisecting the issue using [every-ts](https://www.npmjs.com/package/every-ts#bisecting), which should narrow down the problem to a specific change.
 
-        This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-
-
-        Note: The TypeScript Playground can be used to try older versions of TypeScript.
+        The Playground also supports versions of TypeScript back to TypeScript 3.3.
 
         Please keep and fill in the line that best applies.
       value: |
         - This is a crash
         - This changed between versions ______ and _______
+        - This changed in commit or PR _______
         - This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
         - I was unable to test this on prior versions because _______
     validations:
@@ -54,7 +51,6 @@ body:
 
         This should have the same code as the code snippet below, and use whichever settings are relevant to your report.
 
-
         As a last resort, you can link to a repo, but these will be slower for us to investigate.
       placeholder: 'Playground link with relevant code: https://www.typescriptlang.org/play?#code/PTAEFkE9QYwewCYFNQHM5IM6gBZIE5JA'
     validations:
@@ -65,6 +61,7 @@ body:
       label: 💻 Code
       description: |
         Please post the relevant code sample here as well.
+
         This code and the Playground code should be the same, do not use separate examples.
 
         We can quickly address your report if:
@@ -74,6 +71,7 @@ body:
           - The incorrectness of the behavior is readily apparent from reading the sample.
 
         Reports are slower to investigate if:
+
           - We have to pare too much extraneous code.
           - We have to clone a large repo and validate that the problem isn't elsewhere.
           - The sample is confusing or doesn't clearly demonstrate what's wrong.

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -15,8 +15,7 @@ body:
 
         The "Common Feature Requests" section of the FAQ lists many popular requests: https://github.com/Microsoft/TypeScript/wiki/FAQ#common-feature-requests
       placeholder: |
-        List of keywords you searched for before creating this issue.
-        Write them down here so that others can find this suggestion more easily and help provide feedback.
+        List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
 
         e.g. "isArray readonly", "regex string types", "json const assertion import"
     validations:
@@ -26,9 +25,7 @@ body:
     attributes:
       label: '✅ Viability Checklist'
       description: |
-        Suggestions that don't meet all these criteria are very, very unlikely to be accepted.
-        We always recommend reviewing the TypeScript design goals before investing time writing
-        a proposal for ideas outside the scope of the project.
+        Suggestions that don't meet all these criteria are very, very unlikely to be accepted. We always recommend reviewing the TypeScript design goals before investing time writing a proposal for ideas outside the scope of the project.
 
         My suggestion meets the following guidelines.
       options:
@@ -40,6 +37,8 @@ body:
           required: true
         - label: This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
           required: true
+        - label: "This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types"
+          required: true
         - label: 'This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals'
           required: true
   - type: textarea
@@ -54,8 +53,7 @@ body:
     attributes:
       label: '📃 Motivating Example'
       description: |
-        If you were announcing this feature in a blog post, what's a short
-        explanation that shows a developer why this feature improves the language?
+        If you were announcing this feature in a blog post, what's a short explanation that shows a developer why this feature improves the language?
     validations:
       required: true
   - type: textarea

.github/ISSUE_TEMPLATE/lib_change.yml

@@ -1,5 +1,5 @@
 name: 'Library change'
-description: 'Fix or improve issues with built-in type definitions like `lib.dom.d.ts`, `lib.es6.d.ts`, etc.'
+description: 'Fix or improve issues with built-in type definitions like `lib.es6.d.ts`, etc.'
 body:
   - type: markdown
     attributes:
@@ -12,18 +12,13 @@ body:
         * Array methods - see https://github.com/microsoft/TypeScript/issues/36554
         * `parseInt`, `parseFloat`, `isFinite`, `isNaN`, etc. - see https://github.com/microsoft/TypeScript/issues/4002
 
-
-        The DOM lib is maintained elsewhere and you can skip a step by filing issues/PRs for the DOM at that repo.
-        See https://github.com/microsoft/TypeScript-DOM-lib-generator
+        The DOM lib is maintained elsewhere and you can skip a step by filing issues/PRs for the DOM at that repo. See https://github.com/microsoft/TypeScript-DOM-lib-generator
   - type: markdown
     attributes:
       value: |
-        If you're missing common new methods like `Array.includes`, you may have a misconfigured project.
-        Try setting `lib: "es2020"` and checking whether the type you want is present.
-        You can diagnose further by running `tsc` with `--listFilesOnly` or `--showConfig`.
+        If you're missing common new methods like `Array.includes`, you may have a misconfigured project. Try setting `lib: "es2020"` and checking whether the type you want is present. You can diagnose further by running `tsc` with `--listFilesOnly` or `--showConfig`.
 
-        Conversely, if you are seeing built-in methods you expect to *not* see, check your 'lib' setting or review your dependencies for lib/reference directives that might be polluting
-        your global scope. This is common when using the 'node' type library. See https://github.com/microsoft/TypeScript/issues/40184
+        Conversely, if you are seeing built-in methods you expect to *not* see, check your 'lib' setting or review your dependencies for lib/reference directives that might be polluting your global scope. This is common when using the 'node' type library. See https://github.com/microsoft/TypeScript/issues/40184
   - type: input
     id: compilation_target
     attributes:
@@ -58,5 +53,4 @@ body:
     attributes:
       label: 'Documentation Link'
       description: |
-        Link to relevant documentation (e.g. MDN, W3C, ECMAScript Spec) to consult for this property.
-        Note that lib.dom.d.ts intentionally does not include browser-specific extensions or early experimental features.
+        Link to relevant documentation (e.g. MDN, W3C, ECMAScript Spec) to consult for this property. Note that lib.dom.d.ts intentionally does not include browser-specific extensions or early experimental features.

.github/ISSUE_TEMPLATE/module_resolution.yml

@@ -27,8 +27,7 @@ body:
         4. The configuration of the target module
         5. A difference in runtime behavior
 
-        You will also be required to post a cloneable repository.
-        This repo must involve running `tsc`, not a third-party tool (e.g. vue-tsc, ngc, expo, ...)
+        You will also be required to post a cloneable repository. This repo must involve running `tsc`, not a third-party tool (e.g. vue-tsc, ngc, expo, ...)
 
   - type: input
     id: repo-url

.github/dependabot.yml

@@ -0,0 +1,15 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: 'github-actions'
+    directory: '/'
+    schedule:
+      interval: 'weekly'
+    groups:
+      github-actions:
+        patterns:
+          - '*'

.github/pr_owners.txt

@@ -13,3 +13,4 @@ jakebailey
 DanielRosenwasser
 navya9singh
 iisaduan
+dependabot

.github/workflows/accept-baselines-fix-lints.yaml

@@ -16,12 +16,11 @@ jobs:
   build:
     runs-on: ubuntu-latest
 
-    permissions:
-      contents: write
-
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+        with:
+          token: ${{ secrets.TS_BOT_GITHUB_TOKEN }}
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
 
       - name: Configure Git, Run Tests, Update Baselines, Apply Fixes
         run: |

.github/workflows/ci.yml

@@ -39,9 +39,9 @@ jobs:
     name: Test Node ${{ matrix.node-version }} with --bundle=${{ matrix.bundle }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - name: Use node version ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: ${{ matrix.node-version }}
           check-latest: true
@@ -55,8 +55,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -69,22 +69,19 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
       - run: npm ci
 
-      # TODO: The cache fails when copied between GHA runners. See:
-      # https://github.com/dprint/dprint/issues/734
-      # https://github.com/dprint/dprint/issues/735
-      # - uses: actions/cache@v3
-      #   with:
-      #     path: ~/.cache/dprint
-      #     key: ${{ runner.os }}-dprint-${{ hashFiles('package-lock.json', '.dprint.jsonc') }}
-      #     restore-keys: |
-      #       ${{ runner.os }}-dprint-
+      - uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 # v3.3.2
+        with:
+          path: ~/.cache/dprint
+          key: ${{ runner.os }}-dprint-${{ hashFiles('package-lock.json', '.dprint.jsonc') }}
+          restore-keys: |
+            ${{ runner.os }}-dprint-
 
       - name: Check formatting
         run: npx dprint check
@@ -93,15 +90,15 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
       - run: npm ci
 
-      - name: Adding playwright
-        run: npm install --no-save --no-package-lock playwright
+      - name: Installing browsers
+        run: npx playwright install --with-deps
 
       - name: Validate the browser can import TypeScript
         run: npx hereby test-browser-integration
@@ -110,8 +107,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -124,9 +121,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -165,16 +162,16 @@ jobs:
     if: github.event_name == 'pull_request'
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           path: pr
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           path: base
           ref: ${{ github.base_ref }}
 
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -207,8 +204,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -224,8 +221,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true
@@ -244,8 +241,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
         with:
           node-version: '*'
           check-latest: true

.github/workflows/codeql.yml

@@ -42,11 +42,11 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@v2
+        uses: github/codeql-action/init@407ffafae6a767df3e0230c3df91b6443ae8df75 # v2.22.8
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -56,7 +56,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@v2
+        uses: github/codeql-action/autobuild@407ffafae6a767df3e0230c3df91b6443ae8df75 # v2.22.8
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -70,4 +70,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v2
+        uses: github/codeql-action/analyze@407ffafae6a767df3e0230c3df91b6443ae8df75 # v2.22.8