Fix bug where generic type parameters weren't considered possibly type parameters.

Author: kpdonn

src/compiler/checker.ts

@@ -9614,9 +9614,9 @@ namespace ts {
             return type;
         }
 
-        function maybeTypeParameterReference(node: Node) {
+        function maybeTypeParameterReference(node: Node, genericTypeParameter: boolean) {
             return !(node.kind === SyntaxKind.QualifiedName ||
-                node.parent.kind === SyntaxKind.TypeReference && (<TypeReferenceNode>node.parent).typeArguments && node === (<TypeReferenceNode>node.parent).typeName);
+               !genericTypeParameter && node.parent.kind === SyntaxKind.TypeReference && (<TypeReferenceNode>node.parent).typeArguments && node === (<TypeReferenceNode>node.parent).typeName);
         }
 
         function isTypeParameterPossiblyReferenced(tp: TypeParameter, node: Node) {
@@ -9635,7 +9635,7 @@ namespace ts {
                     case SyntaxKind.ThisType:
                         return tp.isThisType;
                     case SyntaxKind.Identifier:
-                        return !tp.isThisType && isPartOfTypeNode(node) && maybeTypeParameterReference(node) &&
+                        return !tp.isThisType && isPartOfTypeNode(node) && maybeTypeParameterReference(node, !!tp.typeParameters) &&
                             getTypeFromTypeNode(<TypeNode>node) === tp;
                     case SyntaxKind.TypeQuery:
                         return true;

tests/baselines/reference/higherKindedTypesLift3.errors.txt

@@ -1,4 +1,5 @@
-tests/cases/compiler/higherKindedTypesLift3.ts(24,7): error TS2322: Type 'LC' is not assignable to type 'number[]'.
+tests/cases/compiler/higherKindedTypesLift3.ts(26,40): error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'string[]'.
+  Type 'number' is not assignable to type 'string'.
 
 
 ==== tests/cases/compiler/higherKindedTypesLift3.ts (1 errors) ====
@@ -26,9 +27,10 @@ tests/cases/compiler/higherKindedTypesLift3.ts(24,7): error TS2322: Type 'LC' is
 
     const result = liftedStringLength(arrayOfStrings);
     const expectedType: Array<number> = result;
-          ~~~~~~~~~~~~
-!!! error TS2322: Type 'LC' is not assignable to type 'number[]'.
 
     const expectError = liftedStringLength(result)
+                                           ~~~~~~
+!!! error TS2345: Argument of type 'number[]' is not assignable to parameter of type 'string[]'.
+!!! error TS2345:   Type 'number' is not assignable to type 'string'.
 
 

tests/baselines/reference/higherKindedTypesLift3.types

@@ -65,8 +65,8 @@ declare function stringLength(strarg: string): number
 >strarg : string
 
 const liftedStringLength = liftedArray(stringLength);
->liftedStringLength : (a: LC) => LC
->liftedArray(stringLength) : (a: LC) => LC
+>liftedStringLength : (a: string[]) => number[]
+>liftedArray(stringLength) : (a: string[]) => number[]
 >liftedArray : LiftedResult<T[]>
 >stringLength : (strarg: string) => number
 
@@ -75,20 +75,20 @@ declare const arrayOfStrings: Array<string>;
 >Array : T[]
 
 const result = liftedStringLength(arrayOfStrings);
->result : LC
->liftedStringLength(arrayOfStrings) : LC
->liftedStringLength : (a: LC) => LC
+>result : number[]
+>liftedStringLength(arrayOfStrings) : number[]
+>liftedStringLength : (a: string[]) => number[]
 >arrayOfStrings : string[]
 
 const expectedType: Array<number> = result;
 >expectedType : number[]
 >Array : T[]
->result : LC
+>result : number[]
 
 const expectError = liftedStringLength(result)
->expectError : LC
->liftedStringLength(result) : LC
->liftedStringLength : (a: LC) => LC
->result : LC
+>expectError : number[]
+>liftedStringLength(result) : number[]
+>liftedStringLength : (a: string[]) => number[]
+>result : number[]