Skip to content

Commit 87ee0a7

Browse files
Pranshu-NegiPranshu-Negi
authored
Fail build team deprecated tasks nodejs (#19471)
* Fail AppCenterDistributeV1 task * Fix fail location * Fail AppCenterDistributeV2 task * Fail CondaEnvironmentV1 task * Fail DotNetCoreInstallerV1 task * Fix resjson files * fix task.loc.json files * fix app center distribute v1 task * fix * fix tests * bump task version
1 parent 0529c3d commit 87ee0a7

File tree

40 files changed

+155
-73
lines changed

40 files changed

+155
-73
lines changed

‎Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,6 @@
3838
"loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.",
3939
"loc.messages.FoundMultipleFiles": "Found multiple files matching %s.",
4040
"loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.",
41-
"loc.messages.FailedToFindFile": "Failed to find %s at %s."
41+
"loc.messages.FailedToFindFile": "Failed to find %s at %s.",
42+
"loc.messages.DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
4243
}

‎Tasks/AppCenterDistributeV1/appcenterdistribute.ts

+6
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,12 @@ async function run() {
558558
await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent);
559559
}
560560

561+
let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK');
562+
563+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
564+
throw new Error(tl.loc("DeprecatedTask"));
565+
}
566+
561567
tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded"));
562568
} catch (err) {
563569
tl.setResult(tl.TaskResult.Failed, `${err}`);

‎Tasks/AppCenterDistributeV1/task.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 1,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 0
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -201,6 +201,7 @@
201201
"CannotFindAnyFile": "Cannot find any file based on %s.",
202202
"FoundMultipleFiles": "Found multiple files matching %s.",
203203
"FailedToCreateFile": "Failed to create %s with error: %s.",
204-
"FailedToFindFile": "Failed to find %s at %s."
204+
"FailedToFindFile": "Failed to find %s at %s.",
205+
"DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
205206
}
206207
}

‎Tasks/AppCenterDistributeV1/task.loc.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 1,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 0
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -201,6 +201,7 @@
201201
"CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile",
202202
"FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles",
203203
"FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile",
204-
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile"
204+
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile",
205+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
205206
}
206207
}

‎Tasks/AppCenterDistributeV2/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,6 @@
3939
"loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.",
4040
"loc.messages.FoundMultipleFiles": "Found multiple files matching %s.",
4141
"loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.",
42-
"loc.messages.FailedToFindFile": "Failed to find %s at %s."
42+
"loc.messages.FailedToFindFile": "Failed to find %s at %s.",
43+
"loc.messages.DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
4344
}

‎Tasks/AppCenterDistributeV2/appcenterdistribute.ts

+6
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,12 @@ async function run() {
547547
await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent);
548548
}
549549

550+
let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK');
551+
552+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
553+
throw new Error(tl.loc("DeprecatedTask"));
554+
}
555+
550556
tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded"));
551557
} catch (err) {
552558
tl.setResult(tl.TaskResult.Failed, `${err}`);

‎Tasks/AppCenterDistributeV2/task.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 2,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 0
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -203,6 +203,7 @@
203203
"CannotFindAnyFile": "Cannot find any file based on %s.",
204204
"FoundMultipleFiles": "Found multiple files matching %s.",
205205
"FailedToCreateFile": "Failed to create %s with error: %s.",
206-
"FailedToFindFile": "Failed to find %s at %s."
206+
"FailedToFindFile": "Failed to find %s at %s.",
207+
"DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
207208
}
208209
}

‎Tasks/AppCenterDistributeV2/task.loc.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 2,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 0
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -203,6 +203,7 @@
203203
"CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile",
204204
"FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles",
205205
"FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile",
206-
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile"
206+
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile",
207+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
207208
}
208209
}

‎Tasks/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,6 @@
2424
"loc.messages.ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...",
2525
"loc.messages.ParameterRequired": "The `%s` parameter is required",
2626
"loc.messages.PlatformNotRecognized": "Platform not recognized",
27-
"loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s"
27+
"loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s",
28+
"loc.messages.DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task."
2829
}

‎Tasks/CondaEnvironmentV1/main.ts

+5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ import { condaEnvironment } from './conda';
1919
cleanEnvironment: task.getBoolInput('cleanEnvironment')
2020
},
2121
getPlatform());
22+
let shouldFail = task.getVariable('FAIL_DEPRECATED_BUILD_TASK');
23+
24+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
25+
throw new Error(task.loc("DeprecatedTask"));
26+
}
2227
task.setResult(task.TaskResult.Succeeded, "");
2328
} catch (e) {
2429
#if NODE20

‎Tasks/CondaEnvironmentV1/task.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 234,
16+
"Minor": 235,
1717
"Patch": 0
1818
},
1919
"deprecated": true,
@@ -101,6 +101,7 @@
101101
"ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...",
102102
"ParameterRequired": "The `%s` parameter is required",
103103
"PlatformNotRecognized": "Platform not recognized",
104-
"PrependPath": "Prepending PATH environment variable with directory: %s"
104+
"PrependPath": "Prepending PATH environment variable with directory: %s",
105+
"DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task."
105106
}
106107
}

‎Tasks/CondaEnvironmentV1/task.loc.json

+7-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 234,
16+
"Minor": 235,
1717
"Patch": 0
1818
},
1919
"deprecated": true,
@@ -101,6 +101,11 @@
101101
"ReactivateExistingEnvironment": "ms-resource:loc.messages.ReactivateExistingEnvironment",
102102
"ParameterRequired": "ms-resource:loc.messages.ParameterRequired",
103103
"PlatformNotRecognized": "ms-resource:loc.messages.PlatformNotRecognized",
104-
"PrependPath": "ms-resource:loc.messages.PrependPath"
104+
"PrependPath": "ms-resource:loc.messages.PrependPath",
105+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
106+
},
107+
"_buildConfigMapping": {
108+
"Default": "1.234.2",
109+
"Node20-225": "1.234.3"
105110
}
106111
}

‎Tasks/DotNetCoreInstallerV1/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -78,5 +78,6 @@
7878
"loc.messages.FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s",
7979
"loc.messages.VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.",
8080
"loc.messages.VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s",
81-
"loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s"
81+
"loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s",
82+
"loc.messages.DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead."
8283
}

‎Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts

+6
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,12 @@ async function run() {
4141

4242
// Set DOTNET_ROOT for dotnet core Apphost to find runtime since it is installed to a non well-known location.
4343
tl.setVariable('DOTNET_ROOT', installationPath);
44+
45+
let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK');
46+
47+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
48+
throw new Error(tl.loc("DeprecatedTask"));
49+
}
4450
}
4551

4652
function addDotNetCoreToolPath() {

‎Tasks/DotNetCoreInstallerV1/task.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 234,
16+
"Minor": 235,
1717
"Patch": 0
1818
},
1919
"deprecated": true,
@@ -153,6 +153,7 @@
153153
"FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s",
154154
"VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.",
155155
"VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s",
156-
"FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s"
156+
"FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s",
157+
"DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead."
157158
}
158159
}

‎Tasks/DotNetCoreInstallerV1/task.loc.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 234,
16+
"Minor": 235,
1717
"Patch": 0
1818
},
1919
"deprecated": true,
@@ -153,6 +153,7 @@
153153
"FilesDataIsIncorrectInVersion": "ms-resource:loc.messages.FilesDataIsIncorrectInVersion",
154154
"VersionFilesDataIncorrect": "ms-resource:loc.messages.VersionFilesDataIncorrect",
155155
"VersionInformationNotComplete": "ms-resource:loc.messages.VersionInformationNotComplete",
156-
"FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge"
156+
"FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge",
157+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
157158
}
158159
}

‎_generated/AppCenterDistributeV1.versionmap.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Default|1.234.0
2-
Node20_229_7|1.234.1
1+
Default|1.235.0
2+
Node20_229_7|1.235.1

‎_generated/AppCenterDistributeV1_Node20/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,6 @@
3838
"loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.",
3939
"loc.messages.FoundMultipleFiles": "Found multiple files matching %s.",
4040
"loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.",
41-
"loc.messages.FailedToFindFile": "Failed to find %s at %s."
41+
"loc.messages.FailedToFindFile": "Failed to find %s at %s.",
42+
"loc.messages.DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
4243
}

‎_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts

+6
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,12 @@ async function run() {
558558
await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent);
559559
}
560560

561+
let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK');
562+
563+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
564+
throw new Error(tl.loc("DeprecatedTask"));
565+
}
566+
561567
tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded"));
562568
} catch (err) {
563569
tl.setResult(tl.TaskResult.Failed, `${err}`);

‎_generated/AppCenterDistributeV1_Node20/task.json

+5-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 1,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 1
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -205,10 +205,11 @@
205205
"CannotFindAnyFile": "Cannot find any file based on %s.",
206206
"FoundMultipleFiles": "Found multiple files matching %s.",
207207
"FailedToCreateFile": "Failed to create %s with error: %s.",
208-
"FailedToFindFile": "Failed to find %s at %s."
208+
"FailedToFindFile": "Failed to find %s at %s.",
209+
"DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
209210
},
210211
"_buildConfigMapping": {
211-
"Default": "1.234.0",
212-
"Node20_229_7": "1.234.1"
212+
"Default": "1.235.0",
213+
"Node20_229_7": "1.235.1"
213214
}
214215
}

‎_generated/AppCenterDistributeV1_Node20/task.loc.json

+5-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 1,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 1
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -205,10 +205,11 @@
205205
"CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile",
206206
"FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles",
207207
"FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile",
208-
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile"
208+
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile",
209+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
209210
},
210211
"_buildConfigMapping": {
211-
"Default": "1.234.0",
212-
"Node20_229_7": "1.234.1"
212+
"Default": "1.235.0",
213+
"Node20_229_7": "1.235.1"
213214
}
214215
}

‎_generated/AppCenterDistributeV2.versionmap.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Default|2.234.0
2-
Node20_229_7|2.234.1
1+
Default|2.235.0
2+
Node20_229_7|2.235.1

‎_generated/AppCenterDistributeV2_Node20/Strings/resources.resjson/en-US/resources.resjson

+2-1
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,6 @@
3939
"loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.",
4040
"loc.messages.FoundMultipleFiles": "Found multiple files matching %s.",
4141
"loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.",
42-
"loc.messages.FailedToFindFile": "Failed to find %s at %s."
42+
"loc.messages.FailedToFindFile": "Failed to find %s at %s.",
43+
"loc.messages.DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
4344
}

‎_generated/AppCenterDistributeV2_Node20/appcenterdistribute.ts

+6
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,12 @@ async function run() {
547547
await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent);
548548
}
549549

550+
let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK');
551+
552+
if (shouldFail != null && shouldFail.toLowerCase() === 'true') {
553+
throw new Error(tl.loc("DeprecatedTask"));
554+
}
555+
550556
tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded"));
551557
} catch (err) {
552558
tl.setResult(tl.TaskResult.Failed, `${err}`);

‎_generated/AppCenterDistributeV2_Node20/task.json

+5-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 2,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 1
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -207,10 +207,11 @@
207207
"CannotFindAnyFile": "Cannot find any file based on %s.",
208208
"FoundMultipleFiles": "Found multiple files matching %s.",
209209
"FailedToCreateFile": "Failed to create %s with error: %s.",
210-
"FailedToFindFile": "Failed to find %s at %s."
210+
"FailedToFindFile": "Failed to find %s at %s.",
211+
"DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead."
211212
},
212213
"_buildConfigMapping": {
213-
"Default": "2.234.0",
214-
"Node20_229_7": "2.234.1"
214+
"Default": "2.235.0",
215+
"Node20_229_7": "2.235.1"
215216
}
216217
}

‎_generated/AppCenterDistributeV2_Node20/task.loc.json

+5-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"author": "Microsoft Corporation",
1717
"version": {
1818
"Major": 2,
19-
"Minor": 234,
19+
"Minor": 235,
2020
"Patch": 1
2121
},
2222
"minimumAgentVersion": "2.144.0",
@@ -207,10 +207,11 @@
207207
"CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile",
208208
"FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles",
209209
"FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile",
210-
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile"
210+
"FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile",
211+
"DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask"
211212
},
212213
"_buildConfigMapping": {
213-
"Default": "2.234.0",
214-
"Node20_229_7": "2.234.1"
214+
"Default": "2.235.0",
215+
"Node20_229_7": "2.235.1"
215216
}
216217
}

0 commit comments

Comments
 (0)