Skip to content

Commit b5b4b7d

Browse files
authored
Migrate AzureRmWebAppDeploymentV4 and IISWebAppDeploymentOnMachineGroupV0 to Node20 (#19371)
* Migrate 2 tasks * merge _generated node16 tasks to base
1 parent 336d467 commit b5b4b7d

File tree

257 files changed

+627
-18832
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

257 files changed

+627
-18832
lines changed

_generated/AzureRmWebAppDeploymentV4/package-lock.json renamed to Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package-lock.json

+61-35
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

_generated/AzureRmWebAppDeploymentV4_Node16/package.json renamed to Tasks/AzureRmWebAppDeploymentV4/_buildConfigs/Node20/package.json

+3-4
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,9 @@
1818
"homepage": "https://github.com/Microsoft/azure-pipelines-tasks#readme",
1919
"dependencies": {
2020
"@types/mocha": "^5.2.7",
21-
"@types/node": "^16.11.39",
21+
"@types/node": "^20.3.1",
2222
"@types/q": "1.0.7",
23-
"agent-base": "^6.0.2",
24-
"azure-pipelines-task-lib": "4.4.0",
23+
"azure-pipelines-task-lib": "^3.4.0",
2524
"azure-pipelines-tasks-azure-arm-rest": "3.223.5",
2625
"azure-pipelines-tasks-webdeployment-common": "4.230.6",
2726
"moment": "^2.29.4",
@@ -30,6 +29,6 @@
3029
"xml2js": "^0.6.0"
3130
},
3231
"devDependencies": {
33-
"typescript": "4.0.2"
32+
"typescript": "5.1.6"
3433
}
3534
}

Tasks/AzureRmWebAppDeploymentV4/make.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@
1818
{
1919
"items": [
2020
"node_modules/azure-pipelines-tasks-azure-arm-rest/node_modules/azure-pipelines-task-lib",
21-
"node_modules/azure-pipelines-tasks-webdeployment-common/node_modules/azure-pipelines-task-lib"
21+
"node_modules/azure-pipelines-tasks-webdeployment-common/node_modules/azure-pipelines-task-lib",
22+
"node_modules/https-proxy-agent/node_modules/agent-base"
2223
],
2324
"options": "-Rf"
2425
}

Tasks/AzureRmWebAppDeploymentV4/operations/PublishProfileUtility.ts

-6
Original file line numberDiff line numberDiff line change
@@ -108,15 +108,9 @@ export class PublishProfileUtility {
108108
outStream: process.stdout,
109109
failOnStdErr: true,
110110
windowsVerbatimArguments: true,
111-
#if NODE16
112111
// shell should be true, otherwise see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
113112
// workaround https://github.com/nodejs/node/issues/7367#issuecomment-229728704
114113
shell: true
115-
#elseif NODE20
116-
// shell should be true, otherwise see https://github.com/microsoft/azure-pipelines-tasks/issues/17634
117-
// workaround https://github.com/nodejs/node/issues/7367#issuecomment-229728704
118-
shell: true
119-
#endif
120114
});
121115
} catch (error) {
122116
cmdError = error;

0 commit comments

Comments
 (0)