Exclude new tasks from check downgrading CI step (#19435)

Author: ivanduplenskikh

ci/check-downgrading.js

@@ -12,6 +12,9 @@ const taskVersionBumpingDocUrl = "https://aka.ms/azp-tasks-version-bumping";
 
 const packageEndpoint = process.env['PACKAGE_VERSIONS_ENDPOINT'];
 
+// An example:
+// PACKAGE_TOKEN={token} PACKAGE_VERSIONS_ENDPOINT={package_versions_endpoint} SYSTEM_PULLREQUEST_SOURCEBRANCH=refs/head/{local_branch_name} SYSTEM_PULLREQUEST_TARGETBRANCH={target_branch_eg_master} node ./ci/check-downgrading.js --task "@({tasks_names})" --sprint {current_sprint_number}
+
 if (!packageEndpoint) {
   logToPipeline('error', 'Failed to get info from package endpoint because no endpoint was specified. Try setting the PACKAGE_VERSIONS_ENDPOINT environment variable.')
   process.exit(1);
@@ -66,7 +69,7 @@ function checkMasterVersions(masterTasks, sprint, isReleaseTagExist, isCourtesyW
   return messages;
 }
 
-function compareLocalWithMaster(localTasks, masterTasks, sprint, isReleaseTagExist, isCourtesyWeek) {
+function compareLocalToMaster(localTasks, masterTasks, sprint) {
   const messages = [];
 
   for (const localTask of localTasks) {
@@ -94,6 +97,22 @@ function compareLocalWithMaster(localTasks, masterTasks, sprint, isReleaseTagExi
       });
       continue;
     }
+  }
+
+  return messages;
+}
+
+function checkLocalVersions(localTasks, sprint, isReleaseTagExist, isCourtesyWeek) {
+  const messages = [];
+
+  for (const localTask of localTasks) {
+    if (localTask.version.minor < sprint) {
+      messages.push({
+        type: 'error',
+        payload: `${localTask.name} have to be upgraded (task.json, task.loc.json) from v${localTask.version.minor} to v${sprint} at least since local minor version is less than the sprint version(${taskVersionBumpingDocUrl})`
+      });
+      continue;
+    }
 
     if (localTask.version.minor === sprint && isCourtesyWeek) {
       messages.push({
@@ -115,7 +134,7 @@ function compareLocalWithMaster(localTasks, masterTasks, sprint, isReleaseTagExi
   return messages;
 }
 
-function getTasksVersions(tasks, basepath) {
+function readVersionsFromTaskJsons(tasks, basepath) {
   return tasks.map(x => {
     const taskJSONPath = join(basepath, 'Tasks' , x, 'task.json');
 
@@ -147,7 +166,7 @@ async function clientWrapper(url) {
   }
 }
 
-async function getFeedTasksVersions() {
+async function getTaskVersionsFromFeed() {
   const { result, statusCode } = await clientWrapper(packageEndpoint);
 
   if (statusCode !== 200) {
@@ -165,7 +184,7 @@ async function getFeedTasksVersions() {
     }));
 }
 
-function compareLocalWithFeed(localTasks, feedTasks, sprint) {
+function compareLocalToFeed(localTasks, feedTasks, sprint) {
   const messages = [];
 
   for (const localTask of localTasks) {
@@ -221,26 +240,40 @@ function compareLocalTaskLoc(localTasks) {
   return messages;
 }
 
-function getChangedTaskJsonFromMaster(names) {
+function loadTaskJsonsFromMaster(names) {
   names.forEach(x => {
     mkdir('-p', join(tempMasterTasksPath, 'Tasks', x));
     run(`git show origin/master:Tasks/${x}/task.json > ${tempMasterTasksPath.split(sep).join(posix.sep)}/Tasks/${x}/task.json`);
   });
 }
 
+function doesTaskExistInMasterBranch(name) {
+  try {
+    // If task.json doesn't exist in the main branch it means that it's a new task
+    run(`git cat-file -e origin/master:Tasks/${name}/task.json`, true);
+  } catch (error) {
+    return false;
+  }
+
+  return true;
+}
+
 async function main({ task, sprint, week }) {
-  const changedTasksNames = resolveTaskList(task);
-  const localTasks = getTasksVersions(changedTasksNames, join(__dirname, '..'));
-  getChangedTaskJsonFromMaster(changedTasksNames);
-  const masterTasks = getTasksVersions(changedTasksNames, tempMasterTasksPath);
-  const feedTasks = await getFeedTasksVersions();
+  const taskList = resolveTaskList(task);
+
+  const localTasks = readVersionsFromTaskJsons(taskList, join(__dirname, '..'));
+  const masterTaskList = taskList.filter(x => doesTaskExistInMasterBranch(x));
+  loadTaskJsonsFromMaster(masterTaskList);
+  const masterTasks = readVersionsFromTaskJsons(masterTaskList, tempMasterTasksPath);
+  const feedTaskVersions = await getTaskVersionsFromFeed();
   const isReleaseTagExist = run(`git tag -l v${sprint}`).length !== 0;
   const isCourtesyWeek = week === 3;
 
   const messages = [
     ...checkMasterVersions(masterTasks, sprint, isReleaseTagExist, isCourtesyWeek),
-    ...compareLocalWithMaster(localTasks, masterTasks, sprint, isReleaseTagExist, isCourtesyWeek),
-    ...compareLocalWithFeed(localTasks, feedTasks, sprint),
+    ...compareLocalToMaster(localTasks, masterTasks, sprint),
+    ...checkLocalVersions(localTasks, sprint, isReleaseTagExist, isCourtesyWeek),
+    ...compareLocalToFeed(localTasks, feedTaskVersions, sprint),
     ...compareLocalTaskLoc(localTasks)
   ];