Merge pull request #85 from galrito/bugfix/#5418

Fix data loss with null being returned on int numbers

Author: baywet

CHANGELOG.md

@@ -11,6 +11,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+## [1.3.1]
+
+### Added
+
+### Changed
+- fix(serialization): Float serialization also accepts integer values. [#85](https://github.com/microsoft/kiota-serialization-json-php/pull/85)
+
 ## [1.3.0]
 
 ### Added

src/JsonParseNode.php

@@ -74,7 +74,13 @@ public function getIntegerValue(): ?int {
      * @inheritDoc
      */
     public function getFloatValue(): ?float {
-        return is_float($this->jsonNode) ? $this->jsonNode : null;
+        if (is_float($this->jsonNode)) {
+            return $this->jsonNode;
+        }
+        if (is_int($this->jsonNode)) {
+            return floatval($this->jsonNode);
+        }
+        return null;
     }
 
     /**

tests/JsonParseNodeTest.php

@@ -62,12 +62,18 @@ public function testGetObjectValue(): void {
         $this->assertEquals(123.122, $expected->getHeight());
     }
 
-    public function testGetFloatValue(): void {
+    public function testGetFloatValueWithFloat(): void {
         $this->parseNode = new JsonParseNode(1243.12);
         $expected = $this->parseNode->getFloatValue();
         $this->assertEquals(1243.12, $expected);
     }
 
+    public function testGetFloatValueWithInt(): void {
+        $this->parseNode = new JsonParseNode(1243);
+        $expected = $this->parseNode->getFloatValue();
+        $this->assertEquals(1243.00, $expected);
+    }
+
     /**
      * @throws Exception
      */