Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkItDown resets the warning filter #1068

Open
AdrianVollmer opened this issue Feb 27, 2025 · 2 comments
Open

MarkItDown resets the warning filter #1068

AdrianVollmer opened this issue Feb 27, 2025 · 2 comments

Comments

@AdrianVollmer
Copy link

Hey, i think this is an amazing project!

I started to use markitdown in one of my projects and suddenly I got tons of warnings. I suspect it's because of this line:

According to the docs, catch_warning is not thread safe. I'm using markitdown in threads. Besides, I'm not sure why resetwarnings() is called at all. A lot of my dependencies probably have warning filters set, and this line disables them all.

Can we remove the finally clause or perform this check differently please? Thanks in advance!

@anbian123
Copy link

markitdown 在提取pptx里文本的时候,会提取到元数据

@afourney
Copy link
Member

Thanks for the report. Yes, I should get rid of this part of the code. I'm making some other, relatively large, changes to converters and I'll see if I can remove this for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants