You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
According to the docs, catch_warning is not thread safe. I'm using markitdown in threads. Besides, I'm not sure why resetwarnings() is called at all. A lot of my dependencies probably have warning filters set, and this line disables them all.
Can we remove the finally clause or perform this check differently please? Thanks in advance!
The text was updated successfully, but these errors were encountered:
Thanks for the report. Yes, I should get rid of this part of the code. I'm making some other, relatively large, changes to converters and I'll see if I can remove this for the next release.
Hey, i think this is an amazing project!
I started to use markitdown in one of my projects and suddenly I got tons of warnings. I suspect it's because of this line:
markitdown/packages/markitdown/src/markitdown/converters/_mp3_converter.py
Line 23 in dbdf2c0
According to the docs,
catch_warning
is not thread safe. I'm using markitdown in threads. Besides, I'm not sure whyresetwarnings()
is called at all. A lot of my dependencies probably have warning filters set, and this line disables them all.Can we remove the
finally
clause or perform this check differently please? Thanks in advance!The text was updated successfully, but these errors were encountered: