fix float16 comparison in initializer (#2629)

yufenglee · RyanUnderhill · commit a1178f4aa323 · 2019-12-13T13:53:06.000-08:00
diff --git a/onnxruntime/core/optimizer/utils.cc b/onnxruntime/core/optimizer/utils.cc
@@ -63,7 +63,7 @@ bool IsInitializerWithExpectedValue(const Graph& graph, const NodeArg& input_arg
     }
   } else if (data_type == ONNX_NAMESPACE::TensorProto_DataType_FLOAT16) {
     const MLFloat16* val = init_const->data<MLFloat16>();
-    float diff = std::abs(math::halfToFloat(val[0].val) - static_cast<float>(expected_value));
+    float diff = std::abs(math::halfToFloat(val[0].val) - math::halfToFloat(math::floatToHalf(expected_value)));
     if (diff > FLT_EPSILON) {
       return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ bool IsInitializerWithExpectedValue(const Graph& graph, const NodeArg& input_arg`
`63`	`63`	`}`
`64`	`64`	`} else if (data_type == ONNX_NAMESPACE::TensorProto_DataType_FLOAT16) {`
`65`	`65`	`const MLFloat16* val = init_const->data<MLFloat16>();`
`66`		`- float diff = std::abs(math::halfToFloat(val[0].val) - static_cast<float>(expected_value));`
	`66`	`+ float diff = std::abs(math::halfToFloat(val[0].val) - math::halfToFloat(math::floatToHalf(expected_value)));`
`67`	`67`	`if (diff > FLT_EPSILON) {`
`68`	`68`	`return false;`
`69`	`69`	`}`