Skip to content

Commit 14b849a

Browse files
Get ReactiveNative compiled with Clang 10 (facebook#28362) (#776)
Summary: Pull Request resolved: facebook#28362 Fixed a few compilation errors emitted by Clang 10. Changelog: [iOS] [Fixed] - Get ready for Clang 10 Differential Revision: D20549970 fbshipit-source-id: dc36a85d90d3e43a05f045feb57c6ab6ded67da7 Co-authored-by: Max Ovtsin <[email protected]>
1 parent 70539c7 commit 14b849a

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

React/CxxBridge/RCTCxxBridge.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ - (void)registerExtraLazyModules
796796
#endif
797797
}
798798

799-
- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules
799+
- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules
800800
withDispatchGroup:(dispatch_group_t)dispatchGroup
801801
lazilyDiscovered:(BOOL)lazilyDiscovered
802802
{

ReactCommon/fabric/graphics/platform/ios/Color.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
*/
77

88
#include "Color.h"
9+
#include <cassert>
910

1011
namespace facebook {
1112
namespace react {

ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name
304304
@"%@ has no setter or ivar for its bridge, which is not "
305305
"permitted. You must either @synthesize the bridge property, "
306306
"or provide your own setter method.",
307-
RCTBridgeModuleNameForClass(strongModule));
307+
RCTBridgeModuleNameForClass([strongModule class]));
308308
}
309309
}
310310

0 commit comments

Comments
 (0)