Skip to content

Commit 873520b

Browse files
Pavlos Vinieratosfacebook-github-bot
Pavlos Vinieratos
authored and
facebook-github-bot
committed
Update Xcode projects (#19574)
Summary: A few people have been complaining, including me, that when we compile a react native project, there are a lot of warnings from xcode, suggesting to update the project build settings to the new recommendations. I took the liberty to actually update the xcode projects, so we can finally have these gone, as well as replace some deprecated methods with the new suggested ones. I made two react native projects, one with the regular react native and the other one using this branch. Left is before, right is after: ![screen shot 2018-06-05 at 15 44 34](https://user-images.githubusercontent.com/100233/40979899-6aba12da-68d7-11e8-8630-6c3009b6dc24.png) [IOS] [MINOR] [Xcode] - updated the Xcode projects with the latest suggestions from Xcode 9.3, and replaced a few deprecated methods of iOS with their new replacements. Closes facebook/react-native#19574 Differential Revision: D8489006 Pulled By: hramos fbshipit-source-id: 2922b2e76aca6883c4f5d04e9c511b9fc1029583
1 parent 4fc8870 commit 873520b

File tree

4 files changed

+28
-4
lines changed

4 files changed

+28
-4
lines changed

‎RNTester.xcodeproj/project.pbxproj

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1144,7 +1144,7 @@
11441144
83CBB9F71A601CBA00E9B192 /* Project object */ = {
11451145
isa = PBXProject;
11461146
attributes = {
1147-
LastUpgradeCheck = 0820;
1147+
LastUpgradeCheck = 0940;
11481148
ORGANIZATIONNAME = Facebook;
11491149
TargetAttributes = {
11501150
004D289D1AAF61C70097A701 = {
@@ -2091,7 +2091,9 @@
20912091
CLANG_ENABLE_MODULES = YES;
20922092
CLANG_ENABLE_OBJC_ARC = YES;
20932093
CLANG_WARN_ASSIGN_ENUM = YES;
2094+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
20942095
CLANG_WARN_BOOL_CONVERSION = YES;
2096+
CLANG_WARN_COMMA = YES;
20952097
CLANG_WARN_CONSTANT_CONVERSION = YES;
20962098
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
20972099
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
@@ -2100,9 +2102,13 @@
21002102
CLANG_WARN_ENUM_CONVERSION = YES;
21012103
CLANG_WARN_INFINITE_RECURSION = YES;
21022104
CLANG_WARN_INT_CONVERSION = YES;
2105+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
21032106
CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
21042107
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
2108+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
21052109
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
2110+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
2111+
CLANG_WARN_STRICT_PROTOTYPES = YES;
21062112
CLANG_WARN_SUSPICIOUS_MOVE = YES;
21072113
CLANG_WARN_UNREACHABLE_CODE = YES;
21082114
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -2159,7 +2165,9 @@
21592165
CLANG_ENABLE_MODULES = YES;
21602166
CLANG_ENABLE_OBJC_ARC = YES;
21612167
CLANG_WARN_ASSIGN_ENUM = YES;
2168+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
21622169
CLANG_WARN_BOOL_CONVERSION = YES;
2170+
CLANG_WARN_COMMA = YES;
21632171
CLANG_WARN_CONSTANT_CONVERSION = YES;
21642172
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
21652173
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
@@ -2168,9 +2176,13 @@
21682176
CLANG_WARN_ENUM_CONVERSION = YES;
21692177
CLANG_WARN_INFINITE_RECURSION = YES;
21702178
CLANG_WARN_INT_CONVERSION = YES;
2179+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
21712180
CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
21722181
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
2182+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
21732183
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
2184+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
2185+
CLANG_WARN_STRICT_PROTOTYPES = YES;
21742186
CLANG_WARN_SUSPICIOUS_MOVE = YES;
21752187
CLANG_WARN_UNREACHABLE_CODE = YES;
21762188
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

‎RNTester.xcodeproj/xcshareddata/xcschemes/RNTester-tvOS.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0820"
3+
LastUpgradeVersion = "0940"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "NO"

‎RNTester.xcodeproj/xcshareddata/xcschemes/RNTester.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0820"
3+
LastUpgradeVersion = "0940"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "NO"

‎RNTesterPods.xcodeproj/project.pbxproj

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@
203203
83CBB9F71A601CBA00E9B192 /* Project object */ = {
204204
isa = PBXProject;
205205
attributes = {
206-
LastUpgradeCheck = 0820;
206+
LastUpgradeCheck = 0940;
207207
ORGANIZATIONNAME = Facebook;
208208
TargetAttributes = {
209209
13B07F861A680F5B00A75B9A = {
@@ -415,7 +415,9 @@
415415
CLANG_ENABLE_MODULES = YES;
416416
CLANG_ENABLE_OBJC_ARC = YES;
417417
CLANG_WARN_ASSIGN_ENUM = YES;
418+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
418419
CLANG_WARN_BOOL_CONVERSION = YES;
420+
CLANG_WARN_COMMA = YES;
419421
CLANG_WARN_CONSTANT_CONVERSION = YES;
420422
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
421423
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
@@ -424,9 +426,13 @@
424426
CLANG_WARN_ENUM_CONVERSION = YES;
425427
CLANG_WARN_INFINITE_RECURSION = YES;
426428
CLANG_WARN_INT_CONVERSION = YES;
429+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
427430
CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
428431
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
432+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
429433
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
434+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
435+
CLANG_WARN_STRICT_PROTOTYPES = YES;
430436
CLANG_WARN_SUSPICIOUS_MOVE = YES;
431437
CLANG_WARN_UNREACHABLE_CODE = YES;
432438
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -483,7 +489,9 @@
483489
CLANG_ENABLE_MODULES = YES;
484490
CLANG_ENABLE_OBJC_ARC = YES;
485491
CLANG_WARN_ASSIGN_ENUM = YES;
492+
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
486493
CLANG_WARN_BOOL_CONVERSION = YES;
494+
CLANG_WARN_COMMA = YES;
487495
CLANG_WARN_CONSTANT_CONVERSION = YES;
488496
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
489497
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
@@ -492,9 +500,13 @@
492500
CLANG_WARN_ENUM_CONVERSION = YES;
493501
CLANG_WARN_INFINITE_RECURSION = YES;
494502
CLANG_WARN_INT_CONVERSION = YES;
503+
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
495504
CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
496505
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
506+
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
497507
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
508+
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
509+
CLANG_WARN_STRICT_PROTOTYPES = YES;
498510
CLANG_WARN_SUSPICIOUS_MOVE = YES;
499511
CLANG_WARN_UNREACHABLE_CODE = YES;
500512
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

0 commit comments

Comments
 (0)