You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
### Motivation and Context
This PR includes the following changes
1. Bump version of `Microsoft.Azure.Kusto.Data` to version 12.2.2
2. Switch from obsolete `NormalizeTableName` to recommended
`NormalizeName`
Background on this second change:
- The default behavior of `NormalizeTableName` is to only add brackets
if they seem needed, while `NormalizeName` always does.
- Unless you rely on the exact kql generated it shouldn't matter, if you
want to force the old behavior add `NormalizationMode.Classic`
- The normalization of plenty of identifier kinds has been unified, so
you no longer need most of the specialized methods
### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
- [ ]
It.Is<string>(s =>s.Replace(" "," ").StartsWith($".delete table {CollectionName}")&&s.Contains(MemoryRecordKey)),// Replace double spaces with single space to account for the fact that the query is formatted with double spaces and to be future proof
310
+
It.Is<string>(s =>s.Replace(" "," ").StartsWith($".delete table {this._normalisedCollectionName}")&&s.Contains(MemoryRecordKey)),// Replace double spaces with single space to account for the fact that the query is formatted with double spaces and to be future proof
310
311
It.IsAny<ClientRequestProperties>()
311
312
),Times.Once());
312
313
}
@@ -325,7 +326,7 @@ public async Task ItCanRemoveBatchAsync()
0 commit comments