-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Python: Support BetweenFilterClause
or RangeFilterClause
for Redis
#10391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
BetweenFilterClause
or RangeFilterClause
for RedisBetweenFilterClause
or RangeFilterClause
for Redis
@moonbox3, in .net we are looking into using linq for expressing filters, which removes the need for a custom expression tree using filter clauses. Linq is a .net concept though, so not applicable to python. See #10156 Certainly more filter clauses are required beyond what we support today though. They were only intended to be the bare minimum to ship our preview and adding support for not, nesting, or, range filters, etc. will be important. |
BetweenFilterClause
or RangeFilterClause
for RedisBetweenFilterClause
or RangeFilterClause
for Redis
@moonbox3 I see the issue title is set to Python. Will this issue track only for Python. I was porting a movie recommender example written in python to .NET using SK. The python example has a date range search for movies using vector. i need the filter in .NET. how will this make it to .NET SK? |
@lohithgn yeah, as @eavanvalkenburg noted above considerable work has recently gone into augmenting the .NET filtering story, by using LINQ; see issue #10156 (and PR #10273 which was very recently merged). Date range search is something that's still on my todo to properly test, but the infrastructure is there for expressing any sort of filter. |
@roji do i need to be on latest of Redis connector nuget to get the infra you are talking about? Any code examples i can see.. |
There's a request extend our current
FilterClauseBase
, which only has EqualTo and AnyTagsEqualTo. We can do this by creating a new filter clause, likeBetweenFilterClause
orRangeFilterClause
.This also means we should extend the
VectorSearchFilter
(orSearchFilter
) to allow.between(...)
.The original ask is for Redis, but we should support this for others, too, if possible. For Redis we need to update
_filters_to_redis_filters
.Tagging @westey-m for visibility for comments related to if there is (planned) support in .Net.
The text was updated successfully, but these errors were encountered: