Skip to content

Commit 052dc78

Browse files
committed
more nits
1 parent fd8b083 commit 052dc78

File tree

6 files changed

+11
-25
lines changed

6 files changed

+11
-25
lines changed

src/cascadia/TerminalApp/Pane.cpp

+4-18
Original file line numberDiff line numberDiff line change
@@ -1081,30 +1081,16 @@ TermControl Pane::GetLastFocusedTerminalControl()
10811081
{
10821082
if (p->_IsLeaf())
10831083
{
1084-
if (const auto& terminalPane{ p->_content.try_as<TerminalPaneContent>() })
1085-
{
1086-
return terminalPane.GetTerminal();
1087-
}
1088-
else
1089-
{
1090-
return nullptr;
1091-
}
1084+
return p->GetTerminalControl();
10921085
}
10931086
pane = p;
10941087
}
10951088
// We didn't find our child somehow, they might have closed under us.
10961089
}
10971090
return _firstChild->GetLastFocusedTerminalControl();
10981091
}
1099-
1100-
if (const auto& terminalPane{ _content.try_as<TerminalPaneContent>() })
1101-
{
1102-
return terminalPane.GetTerminal();
1103-
}
1104-
else
1105-
{
1106-
return nullptr;
1107-
}
1092+
// we _are_ a leaf.
1093+
return GetTerminalControl();
11081094
}
11091095

11101096
// Method Description:
@@ -1118,7 +1104,7 @@ TermControl Pane::GetTerminalControl() const
11181104
{
11191105
if (const auto& terminalPane{ _getTerminalContent() })
11201106
{
1121-
return terminalPane.GetTerminal();
1107+
return terminalPane.GetTermControl();
11221108
}
11231109
else
11241110
{

src/cascadia/TerminalApp/TerminalPage.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1306,7 +1306,7 @@ namespace winrt::TerminalApp::implementation
13061306
return nullptr;
13071307
}
13081308

1309-
const auto& control{ paneContent.GetTerminal() };
1309+
const auto& control{ paneContent.GetTermControl() };
13101310
if (control == nullptr)
13111311
{
13121312
return nullptr;
@@ -3219,7 +3219,7 @@ namespace winrt::TerminalApp::implementation
32193219
// for nulls
32203220
if (const auto& connection{ _duplicateConnectionForRestart(paneContent) })
32213221
{
3222-
paneContent.GetTerminal().Connection(connection);
3222+
paneContent.GetTermControl().Connection(connection);
32233223
connection.Start();
32243224
}
32253225
}

src/cascadia/TerminalApp/TerminalPaneContent.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ namespace winrt::TerminalApp::implementation
4646
{
4747
return _control;
4848
}
49-
winrt::Microsoft::Terminal::Control::TermControl TerminalPaneContent::GetTerminal()
49+
winrt::Microsoft::Terminal::Control::TermControl TerminalPaneContent::GetTermControl()
5050
{
5151
return _control;
5252
}

src/cascadia/TerminalApp/TerminalPaneContent.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ namespace winrt::TerminalApp::implementation
2222
const winrt::Microsoft::Terminal::Control::TermControl& control);
2323

2424
winrt::Windows::UI::Xaml::FrameworkElement GetRoot();
25-
winrt::Microsoft::Terminal::Control::TermControl GetTerminal();
25+
winrt::Microsoft::Terminal::Control::TermControl GetTermControl();
2626
winrt::Windows::Foundation::Size MinimumSize();
2727
void Focus(winrt::Windows::UI::Xaml::FocusState reason = winrt::Windows::UI::Xaml::FocusState::Programmatic);
2828
void Close();

src/cascadia/TerminalApp/TerminalPaneContent.idl

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace TerminalApp
77
{
88
[default_interface] runtimeclass TerminalPaneContent : IPaneContent, ISnappable
99
{
10-
Microsoft.Terminal.Control.TermControl GetTerminal();
10+
Microsoft.Terminal.Control.TermControl GetTermControl();
1111

1212
void UpdateSettings(const Microsoft.Terminal.Settings.Model.TerminalSettingsCreateResult settings,
1313
const Microsoft.Terminal.Settings.Model.Profile profile);

src/cascadia/TerminalApp/TerminalTab.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,7 @@ namespace winrt::TerminalApp::implementation
10401040
{
10411041
if (const auto& termContent{ content.try_as<TerminalApp::TerminalPaneContent>() })
10421042
{
1043-
_addBroadcastHandlers(termContent.GetTerminal(), events);
1043+
_addBroadcastHandlers(termContent.GetTermControl(), events);
10441044
}
10451045
}
10461046

@@ -1722,7 +1722,7 @@ namespace winrt::TerminalApp::implementation
17221722
{
17231723
if (const auto termContent{ content.try_as<winrt::TerminalApp::TerminalPaneContent>() })
17241724
{
1725-
return termContent.GetTerminal();
1725+
return termContent.GetTermControl();
17261726
}
17271727
}
17281728
return nullptr;

0 commit comments

Comments
 (0)