Skip to content

Commit 216cc3f

Browse files
committed
Merge branch 'dev/migrie/fhl/scratchpad-pane' into dev/migrie/f/sui-panes
2 parents 77022e9 + d417934 commit 216cc3f

File tree

1 file changed

+1
-25
lines changed

1 file changed

+1
-25
lines changed

src/cascadia/TerminalApp/TerminalTab.cpp

+1-25
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,7 @@ namespace winrt::TerminalApp::implementation
10721072
{
10731073
// If visual is set, we need to bubble this event all the way to app host to flash the taskbar
10741074
// In this part of the chain we bubble it from the hosting tab to the page
1075-
tab->_TabRaiseVisualBellHandlers();
1075+
tab->TabRaiseVisualBell.raise();
10761076
}
10771077

10781078
// Show the bell indicator in the tab header
@@ -1351,30 +1351,6 @@ namespace winrt::TerminalApp::implementation
13511351
}
13521352
});
13531353

1354-
// Add a PaneRaiseBell event handler to the Pane
1355-
auto bellToken = pane->PaneRaiseBell([weakThis](auto&& /*s*/, auto&& visual) {
1356-
if (auto tab{ weakThis.get() })
1357-
{
1358-
if (visual)
1359-
{
1360-
// If visual is set, we need to bubble this event all the way to app host to flash the taskbar
1361-
// In this part of the chain we bubble it from the hosting tab to the page
1362-
tab->TabRaiseVisualBell.raise();
1363-
}
1364-
1365-
// Show the bell indicator in the tab header
1366-
tab->ShowBellIndicator(true);
1367-
1368-
// If this tab is focused, activate the bell indicator timer, which will
1369-
// remove the bell indicator once it fires
1370-
// (otherwise, the indicator is removed when the tab gets focus)
1371-
if (tab->_focusState != WUX::FocusState::Unfocused)
1372-
{
1373-
tab->ActivateBellIndicatorTimer();
1374-
}
1375-
}
1376-
});
1377-
13781354
// box the event token so that we can give a reference to it in the
13791355
// event handler.
13801356
auto detachedToken = std::make_shared<winrt::event_token>();

0 commit comments

Comments
 (0)