yes yes subclasses are hard in C

zadjii-msft · zadjii-msft · commit b706a6d679b2 · 2024-02-21T11:01:36.000-06:00
diff --git a/src/cascadia/TerminalApp/FilteredCommand.h b/src/cascadia/TerminalApp/FilteredCommand.h
@@ -19,7 +19,7 @@ namespace winrt::TerminalApp::implementation
         FilteredCommand() = default;
         FilteredCommand(const winrt::TerminalApp::PaletteItem& item);
 
-        void UpdateFilter(const winrt::hstring& filter);
+        virtual void UpdateFilter(const winrt::hstring& filter);
 
         static int Compare(const winrt::TerminalApp::FilteredCommand& first, const winrt::TerminalApp::FilteredCommand& second);
 
diff --git a/src/cascadia/TerminalApp/TasksPaneContent.h b/src/cascadia/TerminalApp/TasksPaneContent.h
@@ -117,7 +117,7 @@ namespace winrt::TerminalApp::implementation
         // FilteredCommand() = default;
         // FilteredCommand(const winrt::TerminalApp::PaletteItem& item);
 
-        void UpdateFilter(const winrt::hstring& filter)
+        void UpdateFilter(const winrt::hstring& filter) override 
         {
             TerminalApp::implementation::FilteredCommand::UpdateFilter(filter);
             for (const auto& c : _children)

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ namespace winrt::TerminalApp::implementation`
`117`	`117`	`// FilteredCommand() = default;`
`118`	`118`	`// FilteredCommand(const winrt::TerminalApp::PaletteItem& item);`
`119`	`119`
`120`		`- void UpdateFilter(const winrt::hstring& filter)`
	`120`	`+ void UpdateFilter(const winrt::hstring& filter) override`
`121`	`121`	`{`
`122`	`122`	`TerminalApp::implementation::FilteredCommand::UpdateFilter(filter);`
`123`	`123`	`for (const auto& c : _children)`