Disable the context menu command inside a zipped folder (#15236)

jamespack · web-flow · commit fea6eeddfd25 · 2023-04-25T21:36:20.000Z
Closes #15190
diff --git a/src/cascadia/ShellExtension/OpenTerminalHere.cpp b/src/cascadia/ShellExtension/OpenTerminalHere.cpp
@@ -119,7 +119,8 @@ HRESULT OpenTerminalHere::GetState(IShellItemArray* psiItemArray,
 
     SFGAOF attributes;
     const bool isFileSystemItem = psi && (psi->GetAttributes(SFGAO_FILESYSTEM, &attributes) == S_OK);
-    *pCmdState = isFileSystemItem ? ECS_ENABLED : ECS_HIDDEN;
+    const bool isCompressed = psi && (psi->GetAttributes(SFGAO_FOLDER | SFGAO_STREAM, &attributes) == S_OK);
+    *pCmdState = isFileSystemItem && !isCompressed ? ECS_ENABLED : ECS_HIDDEN;
 
     return S_OK;
 }

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,8 @@ HRESULT OpenTerminalHere::GetState(IShellItemArray* psiItemArray,`
`119`	`119`
`120`	`120`	`SFGAOF attributes;`
`121`	`121`	`const bool isFileSystemItem = psi && (psi->GetAttributes(SFGAO_FILESYSTEM, &attributes) == S_OK);`
`122`		`- *pCmdState = isFileSystemItem ? ECS_ENABLED : ECS_HIDDEN;`
	`122`	`+ const bool isCompressed = psi && (psi->GetAttributes(SFGAO_FOLDER \| SFGAO_STREAM, &attributes) == S_OK);`
	`123`	`+ *pCmdState = isFileSystemItem && !isCompressed ? ECS_ENABLED : ECS_HIDDEN;`
`123`	`124`
`124`	`125`	`return S_OK;`
`125`	`126`	`}`