Skip to content

Revert "Build TestPlatform packages in VMR" #15057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

ViktorHofer
Copy link
Member

Reverts #15055

The packages don't build successfully on non-Windows:

  Microsoft.TestPlatform failed with 1 error(s) (0.1s)
    /home/vihofer/git/vstest/.dotnet/sdk/9.0.104/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5019: File not found: 'net48\Microsoft.TestPlatform.VsTestConsole.TranslationLayer.xml'.
  Microsoft.TestPlatform.Portable failed with 1 error(s) (0.1s)
    /home/vihofer/git/vstest/.dotnet/sdk/9.0.104/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5019: File not found: 'net48\Microsoft.TestPlatform.VsTestConsole.TranslationLayer.xml'.

I'm a bit suprised that vstest's CI doesn't build packages on non-Windows. Also, the checked-in nuspecs with the hundreds of lines of assets to include are horrible. They made me open this revert PR instead of attempting to fix the build issue.

@ViktorHofer
Copy link
Member Author

@nohwnd

@nohwnd nohwnd merged commit b1b03ee into main Apr 22, 2025
7 checks passed
@nohwnd nohwnd deleted the revert-15055-BuildTestPlatformPackagesInVMR branch April 22, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants