Skip to content

Commit e35e26b

Browse files
carlocaionekhilman
authored andcommitted
arm: dts: meson: Fix IRQ trigger type for macirq
A long running stress test on a custom board shipping an AXG SoCs and a Realtek RTL8211F PHY revealed that after a few hours the connection speed would drop drastically, from ~1000Mbps to ~3Mbps. At the same time the 'macirq' (eth0) IRQ would stop being triggered at all and as consequence the GMAC IRQs never ACKed. After a painful investigation the problem seemed to be due to a wrong defined IRQ type for the GMAC IRQ that should be LEVEL_HIGH instead of EDGE_RISING. The change in the macirq IRQ type also solved another long standing issue affecting this SoC/PHY where EEE was causing the network connection to die after stressing it with iperf3 (even though much sooner). It's now possible to remove the 'eee-broken-1000t' quirk as well. Fixes: 9c15795 ("ARM: dts: meson8b-odroidc1: ethernet support") Signed-off-by: Carlo Caione <[email protected]> Reviewed-by: Martin Blumenstingl <[email protected]> Tested-by: Martin Blumenstingl <[email protected]> Signed-off-by: Kevin Hilman <[email protected]>
1 parent 19a220d commit e35e26b

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

arch/arm/boot/dts/meson.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@
274274
compatible = "amlogic,meson6-dwmac", "snps,dwmac";
275275
reg = <0xc9410000 0x10000
276276
0xc1108108 0x4>;
277-
interrupts = <GIC_SPI 8 IRQ_TYPE_EDGE_RISING>;
277+
interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
278278
interrupt-names = "macirq";
279279
status = "disabled";
280280
};

arch/arm/boot/dts/meson8b-odroidc1.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@
221221
/* Realtek RTL8211F (0x001cc916) */
222222
eth_phy: ethernet-phy@0 {
223223
reg = <0>;
224-
eee-broken-1000t;
225224
interrupt-parent = <&gpio_intc>;
226225
/* GPIOH_3 */
227226
interrupts = <17 IRQ_TYPE_LEVEL_LOW>;

0 commit comments

Comments
 (0)