Skip to content

unit test fail #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahkeno opened this issue Feb 21, 2019 · 3 comments
Open

unit test fail #1

ahkeno opened this issue Feb 21, 2019 · 3 comments

Comments

@ahkeno
Copy link

ahkeno commented Feb 21, 2019

I clone to from master branch and follow readme.

npm t was fail by 'TOTAL: 4 FAILED, 8 SUCCESS'

@msn0
Copy link
Owner

msn0 commented Feb 21, 2019

Could you provide some more details? If the error says something like

Expected image to match or be a close match to snapshot but was 0.93875% different from snapshot (2253 differing pixels).
See diff for details: /Users/Foo/a6-examples/vrt/__image_snapshots__/__diff_output__/600x400-diff.png

then please take a look into generated diff image. In my case it's something like this https://pasteboard.co/I29QDSa.png

In my case it means that something is going on with puppeteer version, chromium version, color profile, os version, different fonts. Most probably this image was generated several months ago with older version of puppeteer (and older version of Chromium). Because of that I don't recommend vrt tests to be setup with ci/cd (like travis) because it will produce different image images and fail. I wish it to be fully deterministic but it isn't.

Nevertheless these screens are old and should be updated.

@ahkeno
Copy link
Author

ahkeno commented Feb 22, 2019

when I run npm t, it fail with these error

https://pasteboard.co/I2gWtgn.png

Correct me if I miss out any steps.

@msn0
Copy link
Owner

msn0 commented Feb 23, 2019

@ahkeno pull master, try again npm t and let me know if it works for you. I added timeZone option to Intl.DateTimeFormat and it should work right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants