Skip to content

Commit a114a04

Browse files
authored
Internal renaming for code clarity (#28)
* returned -> recevied * minor fix * minor cleanup
1 parent 1ffc041 commit a114a04

7 files changed

+16
-16
lines changed

bind.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ func doBind(sc *Collection, originalInvokeF *provider, originalInitF *provider,
350350
return err
351351
}
352352

353-
inMap, err := generateInputMapper(invokeF, 0, returnedParams, invokeF.upRmap, upVmap, "invoke results")
353+
inMap, err := generateInputMapper(invokeF, 0, receviedParams, invokeF.upRmap, upVmap, "invoke results")
354354
if err != nil {
355355
return err
356356
}

characterize.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ type charContext struct {
1313
inputsAreStatic bool
1414
}
1515

16-
type flowMapType [bypassParams + 1][]typeCode
16+
type flowMapType [lastFlowType][]typeCode
1717

1818
type characterization struct {
1919
name string
@@ -207,7 +207,7 @@ var invokeRegistry = typeRegistry{
207207
a.fm.group = invokeGroup
208208
a.fm.class = invokeFunc
209209
a.fm.flows[outputParams] = toTypeCodes(typesIn(a.t.Elem()))
210-
a.fm.flows[returnedParams] = toTypeCodes(typesOut(a.t.Elem()))
210+
a.fm.flows[receviedParams] = toTypeCodes(typesOut(a.t.Elem()))
211211
a.fm.required = true
212212
a.fm.isSynthetic = true
213213
},
@@ -464,7 +464,7 @@ var handlerRegistry = typeRegistry{
464464
a.fm.flows[inputParams] = toTypeCodes(in)
465465
a.fm.flows[outputParams] = toTypeCodes(typesIn(a.t.In(0)))
466466
a.fm.flows[returnParams] = toTypeCodes(typesOut(a.t))
467-
a.fm.flows[returnedParams] = toTypeCodes(typesOut(a.t.In(0)))
467+
a.fm.flows[receviedParams] = toTypeCodes(typesOut(a.t.In(0)))
468468
},
469469
},
470470

characterize_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ type doesJ struct {
5252
func (dj *doesJ) I() int { return dj.j * 3 }
5353

5454
func params() flowMapType {
55-
return [bypassParams + 1][]typeCode{}
55+
return [lastFlowType][]typeCode{}
5656
}
5757

5858
func (flows flowMapType) returns(f ...typeCode) flowMapType {
@@ -71,7 +71,7 @@ func (flows flowMapType) output(f ...typeCode) flowMapType {
7171
}
7272

7373
func (flows flowMapType) returned(f ...typeCode) flowMapType {
74-
flows[returnedParams] = f
74+
flows[receviedParams] = f
7575
return flows
7676
}
7777

generate.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ func generateWrappers(
186186
if err != nil {
187187
return err
188188
}
189-
retMap, err := generateInputMapper(fm, 0, returnedParams, fm.upRmap, upVmap, "ret(w)") // return values from inner()
189+
retMap, err := generateInputMapper(fm, 0, receviedParams, fm.upRmap, upVmap, "ret(w)") // return values from inner()
190190
if err != nil {
191191
return err
192192
}
@@ -199,8 +199,8 @@ func generateWrappers(
199199
vCopy := v.Copy()
200200
callCount := 0
201201

202-
rTypes := make([]reflect.Type, len(fm.flows[returnedParams]))
203-
for i, tc := range fm.flows[returnedParams] {
202+
rTypes := make([]reflect.Type, len(fm.flows[receviedParams]))
203+
for i, tc := range fm.flows[receviedParams] {
204204
rTypes[i] = tc.Type()
205205
}
206206

include.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -351,11 +351,11 @@ func providesReturns(funcs []*provider, initF *provider) error {
351351
debugf("\tskipping on upward path %s: %s", fm, fm.cannotInclude)
352352
continue
353353
}
354-
err := requireParameters(fm, returns, returnedParams, returnParams, fm.upRmap, "expected return")
354+
err := requireParameters(fm, returns, receviedParams, returnParams, fm.upRmap, "expected return")
355355
if err != nil {
356356
return err
357357
}
358-
provideParameters(fm, returns, returnParams, returnedParams, len(funcs)-i+2)
358+
provideParameters(fm, returns, returnParams, receviedParams, len(funcs)-i+2)
359359
}
360360
return nil
361361
}
@@ -457,7 +457,7 @@ func proposeEliminations(funcs []*provider) []*provider {
457457
useLast bool
458458
}{
459459
{"down", []flowType{inputParams, bypassParams}, true},
460-
{"up", []flowType{returnedParams}, false},
460+
{"up", []flowType{receviedParams}, false},
461461
} {
462462
keep := make([]bool, len(funcs))
463463
toKeep := make([]*provider, 0, len(funcs))

stringer_generated.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,8 @@ const (
9090
outputParams // outputs
9191
// recevied from above
9292
inputParams // inputs
93-
// received from below
94-
returnedParams // returned
93+
// received from below (callee returned)
94+
receviedParams // recevied
9595
// returned from init
9696
bypassParams // bypass
9797
//

0 commit comments

Comments
 (0)