Added extension update modal dialog

(cherry picked from commit 585139b)

Author: Kavakuo

Diff for: src/framework/extensions/extensionstypes.h

@@ -218,6 +218,7 @@ struct Manifest {
     };
 
     Uri uri;
+    io::path_t path;
     Type type = Type::Undefined;
     String title;
     String description;

Diff for: src/framework/extensions/iextensionsprovider.h

@@ -38,6 +38,7 @@ class IExtensionsProvider : MODULE_EXPORT_INTERFACE
     virtual ~IExtensionsProvider() = default;
 
     virtual void reloadExtensions() = 0;
+    virtual Ret removeExtension(const Uri& uri) = 0;
 
     virtual ManifestList manifestList(Filter filter = Filter::All) const = 0;
     virtual async::Notification manifestListChanged() const = 0;

Diff for: src/framework/extensions/internal/extensioninstaller.cpp

@@ -36,11 +36,31 @@ Ret ExtensionInstaller::installExtension(const io::path_t srcPath)
         ExtensionsLoader loader;
         Manifest m = loader.parseManifest(data);
 
-        bool hasSame = provider()->manifest(m.uri).isValid();
-        if (hasSame) {
+        Manifest existingManifest = provider()->manifest(m.uri);
+        bool alreadyInstalled = existingManifest.isValid();
+        if (alreadyInstalled && existingManifest.version == m.version) {
             LOGI() << "already installed: " << m.uri;
+
+            interactive()->info("Info", "The extension is already installed.", { interactive()->buttonData(IInteractive::Button::Ok) });
+
             return make_ok();
         }
+
+        if (alreadyInstalled) {
+            std::stringstream text;
+            text << "The extension \"" << existingManifest.title.toStdString() <<
+                "\" is already installed in a different version.\nDo you want to upgrade?\n\nCurrent version: " <<
+                existingManifest.version.toStdString() << "\nNew version: " << m.version.toStdString();
+            IInteractive::Result result = interactive()->question("Update Extension", text.str(), {
+                interactive()->buttonData(IInteractive::Button::Cancel), interactive()->buttonData(IInteractive::Button::Ok)
+            });
+
+            if (result.button() == int(IInteractive::Button::Ok)) {
+                provider()->removeExtension(existingManifest.uri);
+            } else {
+                return make_ok();
+            }
+        }
     }
 
     // unpack

Diff for: src/framework/extensions/internal/extensioninstaller.h

@@ -5,12 +5,16 @@
 #include "modularity/ioc.h"
 #include "../iextensionsconfiguration.h"
 #include "../iextensionsprovider.h"
+#include "global/iinteractive.h"
+#include "io/ifilesystem.h"
 
 namespace muse::extensions {
 class ExtensionInstaller : public IExtensionInstaller
 {
     muse::GlobalInject<IExtensionsConfiguration> configuration;
     muse::GlobalInject<IExtensionsProvider> provider;
+    muse::GlobalInject<muse::IInteractive> interactive;
+    muse::GlobalInject<io::IFileSystem> fileSystem;
 
 public:
     ExtensionInstaller() = default;

Diff for: src/framework/extensions/internal/extensionsloader.cpp

@@ -80,6 +80,7 @@ ManifestList ExtensionsLoader::manifestList(const io::path_t& rootPath) const
     for (const io::path_t& path : paths) {
         LOGD() << "parsing manifest: " << path;
         Manifest manifest = parseManifest(path);
+        manifest.path = path;
         resolvePaths(manifest, io::FileInfo(path).dirPath());
         manifests.push_back(manifest);
     }

Diff for: src/framework/extensions/internal/extensionsprovider.cpp

@@ -23,6 +23,7 @@
 
 #include "global/containers.h"
 #include "global/async/async.h"
+#include "global/io/fileinfo.h"
 
 #include "extensionsloader.h"
 #include "legacy/extpluginsloader.h"
@@ -68,6 +69,25 @@ void ExtensionsProvider::reloadExtensions()
     m_manifestListChanged.notify();
 }
 
+muse::Ret ExtensionsProvider::removeExtension(const Uri& uri)
+{
+    const Manifest manifest = this->manifest(uri);
+    if (!manifest.isValid()) {
+        return make_ret(Ret::Code::UnknownError);
+    }
+
+    io::path_t path = manifest.path;
+
+    if (!fileSystem()->remove(io::FileInfo(path).dirPath())) {
+        LOGE() << "Failed to delete the folder: " << path;
+        return make_ok();
+    } else {
+        LOGI() << "Successfully deleted the folder: " << path;
+        this->reloadExtensions();
+        return make_ret(Ret::Code::UnknownError);
+    }
+}
+
 ManifestList ExtensionsProvider::manifestList(Filter filter) const
 {
     if (filter == Filter::Enabled) {

Diff for: src/framework/extensions/internal/extensionsprovider.h

@@ -29,19 +29,22 @@
 #include "../iextensionsprovider.h"
 #include "../iextensionsexecpointsregister.h"
 #include "global/iinteractive.h"
+#include "io/ifilesystem.h"
 
 namespace muse::extensions {
 class ExtensionsProvider : public IExtensionsProvider, public Injectable, public async::Asyncable
 {
     Inject<IExtensionsConfiguration> configuration = { this };
     Inject<IExtensionsExecPointsRegister> execPointsRegister = { this };
     Inject<IInteractive> interactive = { this };
+    Inject<io::IFileSystem> fileSystem  = { this };
 
 public:
     ExtensionsProvider(const modularity::ContextPtr& iocCtx)
         : Injectable(iocCtx) {}
 
     void reloadExtensions() override;
+    Ret removeExtension(const Uri& uri) override;
 
     ManifestList manifestList(Filter filter = Filter::All) const override;
     async::Notification manifestListChanged() const override;

Diff for: src/framework/extensions/internal/legacy/extpluginsloader.cpp

@@ -95,6 +95,7 @@ ManifestList ExtPluginsLoader::manifestList(const io::path_t& rootPath) const
         if (!manifest.isValid()) {
             continue;
         }
+        manifest.path = path;
         resolvePaths(manifest, io::FileInfo(path).dirPath());
         manifests.push_back(manifest);
     }