Skip to content

Commit 3093867

Browse files
authored
Merge pull request #19202 from cbjeukendrup/fix_non_unity
Fix non-unity build
2 parents adfa0af + c930365 commit 3093867

File tree

14 files changed

+131
-56
lines changed

14 files changed

+131
-56
lines changed

src/engraving/libmscore/system.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,12 @@
4343
#include "part.h"
4444
#include "score.h"
4545
#include "segment.h"
46-
#include "select.h"
4746
#include "sig.h"
4847
#include "spacer.h"
4948
#include "spanner.h"
5049
#include "staff.h"
5150
#include "system.h"
5251
#include "systemdivider.h"
53-
#include "textframe.h"
5452
#include "tremolo.h"
5553

5654
#ifndef ENGRAVING_NO_ACCESSIBILITY

src/framework/audio/internal/audioconfiguration.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,10 @@
2424
//TODO: remove with global clearing of Q_OS_*** defines
2525
#include <QtGlobal>
2626

27+
#include "log.h"
2728
#include "settings.h"
2829

29-
#include "log.h"
30+
#include "soundfonttypes.h"
3031

3132
using namespace mu;
3233
using namespace mu::framework;
@@ -43,7 +44,7 @@ static const Settings::Key AUDIO_SAMPLE_RATE_KEY("audio", "io/sampleRate");
4344

4445
static const Settings::Key USER_SOUNDFONTS_PATHS("midi", "application/paths/mySoundfonts");
4546

46-
static const AudioResourceId DEFAULT_SOUND_FONT_NAME = "MS Basic"; // "GeneralUser GS v1.471.sf2"; // "MS Basic.sf3";
47+
static const AudioResourceId DEFAULT_SOUND_FONT_NAME = "MS Basic";
4748
static const AudioResourceMeta DEFAULT_AUDIO_RESOURCE_META
4849
= { DEFAULT_SOUND_FONT_NAME, AudioResourceType::FluidSoundfont, "Fluid", {}, false /*hasNativeEditor*/ };
4950

src/framework/vst/vsttypes.h

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@
2626
#include <unordered_map>
2727
#include <vector>
2828

29+
#if (defined (_MSCVER) || defined (_MSC_VER))
30+
#pragma warning (push)
31+
#pragma warning (disable: 4996)
32+
#else
33+
#pragma GCC diagnostic push
34+
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
35+
#endif
36+
2937
#include "public.sdk/source/vst/hosting/module.h"
3038
#include "public.sdk/source/vst/hosting/plugprovider.h"
3139
#include "public.sdk/source/vst/hosting/hostclasses.h"
@@ -40,6 +48,12 @@
4048
#include "pluginterfaces/vst/ivsteditcontroller.h"
4149
#include "pluginterfaces/vst/ivstmidicontrollers.h"
4250

51+
#if (defined (_MSCVER) || defined (_MSC_VER))
52+
#pragma warning (pop)
53+
#else
54+
#pragma GCC diagnostic pop
55+
#endif
56+
4357
#include "framework/midi/miditypes.h"
4458
#include "io/path.h"
4559
#include "log.h"

src/importexport/mei/internal/meiconverter.cpp

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,33 +22,35 @@
2222

2323
#include "meiconverter.h"
2424

25+
#include <iostream>
26+
#include <sstream>
27+
#include <string>
28+
#include <valarray>
29+
30+
#include "engraving/types/symnames.h"
31+
#include "engraving/types/typesconv.h"
32+
2533
#include "libmscore/accidental.h"
2634
#include "libmscore/breath.h"
2735
#include "libmscore/dynamic.h"
28-
#include "libmscore/jump.h"
2936
#include "libmscore/fermata.h"
37+
#include "libmscore/hairpin.h"
3038
#include "libmscore/harmony.h"
39+
#include "libmscore/jump.h"
3140
#include "libmscore/marker.h"
3241
#include "libmscore/measure.h"
3342
#include "libmscore/note.h"
3443
#include "libmscore/ottava.h"
3544
#include "libmscore/part.h"
3645
#include "libmscore/pitchspelling.h"
46+
#include "libmscore/slurtie.h"
3747
#include "libmscore/staff.h"
3848
#include "libmscore/stafftype.h"
39-
#include "libmscore/utils.h"
4049
#include "libmscore/tempotext.h"
4150
#include "libmscore/text.h"
4251
#include "libmscore/textbase.h"
43-
#include "libmscore/tie.h"
4452
#include "libmscore/tuplet.h"
45-
#include "engraving/types/typesconv.h"
46-
#include "types/symnames.h"
47-
48-
#include <iostream>
49-
#include <string>
50-
#include <sstream>
51-
#include <valarray>
53+
#include "libmscore/utils.h"
5254

5355
using namespace mu::iex::mei;
5456
using namespace mu;

src/importexport/mei/internal/meiconverter.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#define MU_IMPORTEXPORT_MEICONVERTER_H
2525

2626
#include "libmscore/accidental.h"
27-
#include "libmscore/clef.h"
2827
#include "libmscore/interval.h"
2928
#include "libmscore/timesig.h"
3029
#include "libmscore/volta.h"

src/importexport/mei/internal/meiexporter.cpp

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -22,48 +22,50 @@
2222

2323
#include "meiexporter.h"
2424

25-
#include "libmscore/articulation.h"
26-
#include "libmscore/barline.h"
25+
#include <random>
26+
27+
#include "log.h"
28+
#include "types/datetime.h"
29+
2730
#include "libmscore/beam.h"
2831
#include "libmscore/box.h"
2932
#include "libmscore/bracket.h"
33+
#include "libmscore/breath.h"
3034
#include "libmscore/chord.h"
3135
#include "libmscore/clef.h"
3236
#include "libmscore/dynamic.h"
3337
#include "libmscore/factory.h"
38+
#include "libmscore/fermata.h"
3439
#include "libmscore/hairpin.h"
40+
#include "libmscore/harmony.h"
3541
#include "libmscore/jump.h"
36-
#include "libmscore/key.h"
3742
#include "libmscore/keysig.h"
38-
#include "libmscore/lyrics.h"
3943
#include "libmscore/marker.h"
40-
#include "libmscore/masterscore.h"
4144
#include "libmscore/measure.h"
4245
#include "libmscore/note.h"
46+
#include "libmscore/ottava.h"
47+
#include "libmscore/page.h"
4348
#include "libmscore/part.h"
4449
#include "libmscore/rest.h"
50+
#include "libmscore/score.h"
4551
#include "libmscore/segment.h"
4652
#include "libmscore/sig.h"
4753
#include "libmscore/slur.h"
4854
#include "libmscore/staff.h"
55+
#include "libmscore/system.h"
4956
#include "libmscore/tempotext.h"
5057
#include "libmscore/text.h"
5158
#include "libmscore/tie.h"
5259
#include "libmscore/timesig.h"
53-
#include "libmscore/timesig.h"
5460
#include "libmscore/tuplet.h"
5561
#include "libmscore/volta.h"
5662

57-
#include "log.h"
58-
5963
#include "meiconverter.h"
6064

6165
#include "thirdparty/libmei/cmn.h"
6266
#include "thirdparty/libmei/harmony.h"
6367
#include "thirdparty/libmei/shared.h"
6468

65-
#include <random>
66-
6769
using namespace mu::iex::mei;
6870
using namespace mu::engraving;
6971

src/importexport/mei/internal/meiexporter.h

Lines changed: 34 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,53 @@
2323
#ifndef MU_IMPORTEXPORT_MEIEXPORTER_H
2424
#define MU_IMPORTEXPORT_MEIEXPORTER_H
2525

26-
#include "engraving/types/fraction.h"
26+
#include "engraving/types/types.h"
2727

2828
#include "modularity/ioc.h"
2929
#include "imeiconfiguration.h"
3030

31+
#include "thirdparty/libmei/element.h"
32+
#include "thirdparty/libmei/shared.h"
33+
3134
#include "thirdparty/pugixml.hpp"
3235

3336
namespace mu::engraving {
37+
class Beam;
38+
class Breath;
39+
class Chord;
40+
class ChordRest;
41+
class Clef;
42+
class Dynamic;
43+
class EngravingItem;
44+
class Fermata;
45+
class Fermata;
3446
class Fraction;
47+
class Hairpin;
48+
class Harmony;
49+
class Jump;
50+
class Marker;
3551
class Measure;
52+
class Note;
53+
class Ottava;
54+
class Part;
55+
class Rest;
3656
class Score;
57+
class Segment;
58+
class Slur;
59+
class Spanner;
3760
class Staff;
61+
class TempoText;
62+
class TextBase;
63+
class TextLineBase;
64+
class Tie;
65+
class Tuplet;
66+
class VBox;
67+
class Volta;
3868
}
3969

4070
namespace mu::iex::mei {
71+
class UIDRegister;
72+
4173
enum layerElementCounter {
4274
ACCID_L = 0,
4375
BEAM_L,
@@ -187,7 +219,7 @@ class MeiExporter
187219
std::vector<int> m_layerCounterFor;
188220

189221
/** map of abbreviations for element within layers */
190-
inline static std::map<layerElementCounter, String> s_layerXmlIdMap = {
222+
inline static const std::map<layerElementCounter, String> s_layerXmlIdMap = {
191223
{ ACCID_L, u"a" },
192224
{ BEAM_L, u"b" },
193225
{ GRACEGRP_L, u"g" },

src/importexport/mei/internal/meiimporter.cpp

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,36 +22,43 @@
2222

2323
#include "meiimporter.h"
2424

25-
#include "meiconverter.h"
26-
2725
#include "libmscore/articulation.h"
2826
#include "libmscore/barline.h"
27+
#include "libmscore/box.h"
2928
#include "libmscore/bracket.h"
29+
#include "libmscore/breath.h"
3030
#include "libmscore/chord.h"
3131
#include "libmscore/clef.h"
3232
#include "libmscore/dynamic.h"
3333
#include "libmscore/expression.h"
3434
#include "libmscore/factory.h"
35+
#include "libmscore/fermata.h"
36+
#include "libmscore/hairpin.h"
37+
#include "libmscore/harmony.h"
38+
#include "libmscore/jump.h"
3539
#include "libmscore/key.h"
3640
#include "libmscore/keysig.h"
3741
#include "libmscore/layoutbreak.h"
38-
#include "libmscore/lyrics.h"
39-
#include "libmscore/masterscore.h"
42+
#include "libmscore/marker.h"
4043
#include "libmscore/measure.h"
4144
#include "libmscore/note.h"
45+
#include "libmscore/ottava.h"
4246
#include "libmscore/part.h"
4347
#include "libmscore/playtechannotation.h"
4448
#include "libmscore/rest.h"
49+
#include "libmscore/score.h"
4550
#include "libmscore/segment.h"
4651
#include "libmscore/sig.h"
4752
#include "libmscore/slur.h"
4853
#include "libmscore/staff.h"
4954
#include "libmscore/stafftext.h"
55+
#include "libmscore/tempotext.h"
5056
#include "libmscore/text.h"
5157
#include "libmscore/textline.h"
52-
#include "libmscore/timesig.h"
58+
#include "libmscore/tie.h"
5359
#include "libmscore/timesig.h"
5460
#include "libmscore/tuplet.h"
61+
#include "libmscore/utils.h"
5562

5663
#include "meiconverter.h"
5764

src/importexport/mei/internal/meiimporter.h

Lines changed: 24 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,22 +23,38 @@
2323
#ifndef MU_IMPORTEXPORT_MEIIMPORTER_H
2424
#define MU_IMPORTEXPORT_MEIIMPORTER_H
2525

26-
#include "engraving/types/fraction.h"
26+
#include "engraving/types/types.h"
2727

2828
#include "modularity/ioc.h"
2929
#include "imeiconfiguration.h"
3030
#include "io/ifilesystem.h"
3131
#include "io/path.h"
3232

33+
#include "thirdparty/libmei/cmn.h"
34+
#include "thirdparty/libmei/element.h"
35+
#include "thirdparty/libmei/shared.h"
36+
3337
#include "thirdparty/pugixml.hpp"
3438

3539
namespace mu::engraving {
36-
class Fraction;
40+
class Chord;
41+
class ChordRest;
42+
class EngravingItem;
3743
class Measure;
44+
class Note;
45+
class Part;
3846
class Score;
47+
class Spanner;
48+
class Tuplet;
49+
class VBox;
50+
enum class NoteType;
51+
enum class TimeSigType : char;
52+
struct ClefTypeList;
3953
}
4054

4155
namespace mu::iex::mei {
56+
class UIDRegister;
57+
4258
enum GraceReading {
4359
GraceNone = 0,
4460
GraceAsGrp,
@@ -128,7 +144,7 @@ class MeiImporter
128144
*/
129145
void addEndBarLineToMeasure(engraving::Measure* measure, engraving::BarLineType barLineType);
130146
void addLayoutBreakToMeasure(engraving::Measure* measure, engraving::LayoutBreakType layoutBreakType);
131-
void addTextToTitleFrame(VBox*& vBox, const String& str, TextStyleType textStyleType);
147+
void addTextToTitleFrame(engraving::VBox*& vBox, const String& str, engraving::TextStyleType textStyleType);
132148
void addSpannerEnds();
133149

134150
/**
@@ -138,11 +154,11 @@ class MeiImporter
138154
int getVoiceIndex(int staffIdx, int layerN);
139155
void addLog(const std::string& msg, pugi::xml_node node);
140156
bool isNode(pugi::xml_node node, const String& name);
141-
engraving::ChordRest* addChordRest(pugi::xml_node node, Measure* measure, int track, const libmei::Element& meiElement, int& ticks,
142-
bool isRest);
157+
engraving::ChordRest* addChordRest(pugi::xml_node node, engraving::Measure* measure, int track, const libmei::Element& meiElement,
158+
int& ticks, bool isRest);
143159
bool addGraceNotesToChord(engraving::ChordRest* chordRest, bool isAfter = false);
144-
engraving::EngravingItem* addAnnotation(const libmei::Element& meiElement, Measure* measure);
145-
engraving::Spanner* addSpanner(const libmei::Element& meiElement, Measure* measure, pugi::xml_node node);
160+
engraving::EngravingItem* addAnnotation(const libmei::Element& meiElement, engraving::Measure* measure);
161+
engraving::Spanner* addSpanner(const libmei::Element& meiElement, engraving::Measure* measure, pugi::xml_node node);
146162
std::string xmlIdFrom(std::string dataURI);
147163
engraving::ChordRest* findStart(const libmei::Element& meiElement, engraving::Measure* measure);
148164
engraving::ChordRest* findEnd(pugi::xml_node controlNode, const engraving::ChordRest* startChordRest);
@@ -156,7 +172,7 @@ class MeiImporter
156172
/** The uid register */
157173
UIDRegister* m_uids;
158174

159-
Fraction m_ticks;
175+
engraving::Fraction m_ticks;
160176
int m_lastMeasureN;
161177
engraving::Measure* m_lastMeasure;
162178

src/importexport/mei/internal/meireader.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,13 @@
2222

2323
#include "meireader.h"
2424

25-
#include "iinteractive.h"
26-
#include "meiimporter.h"
25+
#include "translation.h"
2726

28-
#include "libmscore/masterscore.h"
2927
#include "engraving/engravingerrors.h"
30-
#include "translation.h"
28+
#include "engraving/libmscore/masterscore.h"
29+
30+
#include "meiimporter.h"
31+
#include "meiconverter.h"
3132

3233
using namespace mu::iex::mei;
3334
using namespace mu::engraving;

0 commit comments

Comments
 (0)