14088: Double-click on a toolbar grip will dock/undock it

Author: krasko78

src/framework/dockwindow/internal/dockbase.h

@@ -184,6 +184,8 @@ public slots:
     DockType type() const;
     KDDockWidgets::DockWidgetQuick* dockWidget() const;
 
+    void doSetFloating(bool floating);
+
 protected slots:
     void applySizeConstraints();
 
@@ -193,7 +195,6 @@ private slots:
 
 private:
     void setUpFrameConnections();
-    void doSetFloating(bool floating);
 
     void writeProperties();
 

src/framework/dockwindow/qml/Muse/Dock/DockToolBar.qml

@@ -42,18 +42,17 @@ DockToolBarView {
     minimumHeight: root.inited ? Math.min(root.contentHeight, root.maximumHeight) : prv.minimumLength
 
     onFloatingChanged: {
-        if (!root.floating) {
-            //! NOTE: The dock widgets system determines the position of a toolbar
-            //  when inserting the toolbar into the app window.
-            //  It may be that the grip button can be moved to a different
-            //  location from where a user wanted to place it.
-            //  Because of this, the mouse area does not emit a signal
-            //  that the user has moved the mouse outside the grip button.
-            //  Therefore, the hover state of the grip button is not reset.
-            //  The hack is to hide and show the grip button to reset the hover state.
-            gripButton.visible = false
-            gripButton.visible = true
-        }
+        //! NOTE: The dock widgets system determines the position of a toolbar
+        //  when inserting the toolbar into the app window.
+        //  It may be that the grip button can be moved to a different
+        //  location from where a user wanted to place it.
+        //  Because of this, the mouse area does not emit a signal
+        //  that the user has moved the mouse outside the grip button.
+        //  Therefore, the hover state of the grip button is not reset.
+        //  Disabling and enabling the mousearea does not reset the hover state.
+        //  The hack is to hide and show the grip button's mousearea to reset the hover state.
+        gripButton.mouseArea.visible = false
+        gripButton.mouseArea.visible = true
     }
 
     QtObject {
@@ -93,6 +92,10 @@ DockToolBarView {
             Component.onCompleted: {
                 root.setDraggableMouseArea(gripButton.mouseArea)
             }
+
+            mouseArea.onDoubleClicked: {
+                root.onGripDoubleClicked()
+            }
         }
 
         Loader {

src/framework/dockwindow/view/docktoolbarview.cpp

@@ -201,3 +201,27 @@ void DockToolBarView::resetToDefault()
 
     setOrientation(Qt::Horizontal);
 }
+
+void DockToolBarView::onGripDoubleClicked()
+{
+    if (KDDockWidgets::DockWidgetBase* dw = m_draggableArea->singleDockWidget()) {
+        bool isFloating = dw->isFloating();
+
+        // If the toolbar is floating, first make it think it is docked so it can update itself
+        // for the docked state and then actually dock it. This is a hack for toolbars that
+        // change their size between the docked and undocked state, e.g. the Playback toolbar.
+        // Otheriwse docking a toolbar that will shrink itself after docking will leave gaps.
+        if (isFloating) {
+            doSetFloating(false);
+        }
+
+        dw->setFloating(!isFloating);
+
+        if (isFloating) {
+            if (dw->isFloating()) { // If it didn't dock for some reason, undo our hack above
+                doSetFloating(true);
+            }
+            emit floatingChanged();
+        }
+    }
+}

src/framework/dockwindow/view/docktoolbarview.h

@@ -56,6 +56,7 @@ class DockToolBarView : public DockBase
     int alignment() const;
 
     Q_INVOKABLE void setDraggableMouseArea(QQuickItem* mouseArea);
+    Q_INVOKABLE void onGripDoubleClicked();
 
     void init() override;
     void resetToDefault() override;