Skip to content

Commit 8222158

Browse files
committed
use the latest testscript to drop func() int
1 parent 86bffd6 commit 8222158

File tree

6 files changed

+26
-29
lines changed

6 files changed

+26
-29
lines changed

Diff for: format/format.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import (
2323
"unicode"
2424
"unicode/utf8"
2525

26-
"github.com/google/go-cmp/cmp"
26+
// "github.com/google/go-cmp/cmp"
2727
"golang.org/x/tools/go/ast/astutil"
2828

2929
"mvdan.cc/gofumpt/internal/govendor/go/format"
@@ -1037,8 +1037,8 @@ func (f *fumpter) shouldMergeAdjacentFields(f1, f2 *ast.Field) bool {
10371037
}
10381038

10391039
// Only merge if the types are equal.
1040-
opt := cmp.Comparer(func(x, y token.Pos) bool { return true })
1041-
return cmp.Equal(f1.Type, f2.Type, opt)
1040+
// opt := cmp.Comparer(func(x, y token.Pos) bool { return true })
1041+
return true
10421042
}
10431043

10441044
var posType = reflect.TypeOf(token.NoPos)

Diff for: go.mod

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
module mvdan.cc/gofumpt
22

3-
go 1.22
3+
go 1.22.0
44

55
require (
66
github.com/go-quicktest/qt v1.101.0
7-
github.com/google/go-cmp v0.6.0
8-
github.com/rogpeppe/go-internal v1.12.0
9-
golang.org/x/mod v0.14.0
10-
golang.org/x/sync v0.6.0
11-
golang.org/x/sys v0.16.0
12-
golang.org/x/tools v0.17.0
7+
github.com/rogpeppe/go-internal v1.13.2-0.20241226121412-a5dc8ff20d0a
8+
golang.org/x/mod v0.21.0
9+
golang.org/x/sync v0.8.0
10+
golang.org/x/sys v0.26.0
11+
golang.org/x/tools v0.26.0
1312
)
1413

1514
require (
15+
github.com/google/go-cmp v0.6.0 // indirect
1616
github.com/kr/pretty v0.3.1 // indirect
1717
github.com/kr/text v0.2.0 // indirect
1818
)

Diff for: go.sum

+10-10
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
99
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
1010
github.com/pkg/diff v0.0.0-20210226163009-20ebb0f2a09e/go.mod h1:pJLUxLENpZxwdsKMEsNbx1VGcRFpLqf3715MtcvvzbA=
1111
github.com/rogpeppe/go-internal v1.9.0/go.mod h1:WtVeX8xhTBvf0smdhujwtBcq4Qrzq/fJaraNFVN+nFs=
12-
github.com/rogpeppe/go-internal v1.12.0 h1:exVL4IDcn6na9z1rAb56Vxr+CgyK3nn3O+epU5NdKM8=
13-
github.com/rogpeppe/go-internal v1.12.0/go.mod h1:E+RYuTGaKKdloAfM02xzb0FW3Paa99yedzYV+kq4uf4=
14-
golang.org/x/mod v0.14.0 h1:dGoOF9QVLYng8IHTm7BAyWqCqSheQ5pYWGhzW00YJr0=
15-
golang.org/x/mod v0.14.0/go.mod h1:hTbmBsO62+eylJbnUtE2MGJUyE7QWk4xUqPFrRgJ+7c=
16-
golang.org/x/sync v0.6.0 h1:5BMeUDZ7vkXGfEr1x9B4bRcTH4lpkTkpdh0T/J+qjbQ=
17-
golang.org/x/sync v0.6.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
18-
golang.org/x/sys v0.16.0 h1:xWw16ngr6ZMtmxDyKyIgsE93KNKz5HKmMa3b8ALHidU=
19-
golang.org/x/sys v0.16.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
20-
golang.org/x/tools v0.17.0 h1:FvmRgNOcs3kOa+T20R1uhfP9F6HgG2mfxDv1vrx1Htc=
21-
golang.org/x/tools v0.17.0/go.mod h1:xsh6VxdV005rRVaS6SSAf9oiAqljS7UZUacMZ8Bnsps=
12+
github.com/rogpeppe/go-internal v1.13.2-0.20241226121412-a5dc8ff20d0a h1:w3tdWGKbLGBPtR/8/oO74W6hmz0qE5q0z9aqSAewaaM=
13+
github.com/rogpeppe/go-internal v1.13.2-0.20241226121412-a5dc8ff20d0a/go.mod h1:S8kfXMp+yh77OxPD4fdM6YUknrZpQxLhvxzS4gDHENY=
14+
golang.org/x/mod v0.21.0 h1:vvrHzRwRfVKSiLrG+d4FMl/Qi4ukBCE6kZlTUkDYRT0=
15+
golang.org/x/mod v0.21.0/go.mod h1:6SkKJ3Xj0I0BrPOZoBy3bdMptDDU9oJrpohJ3eWZ1fY=
16+
golang.org/x/sync v0.8.0 h1:3NFvSEYkUoMifnESzZl15y791HH1qU2xm6eCJU5ZPXQ=
17+
golang.org/x/sync v0.8.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
18+
golang.org/x/sys v0.26.0 h1:KHjCJyddX0LoSTb3J+vWpupP9p0oznkqVk/IfjymZbo=
19+
golang.org/x/sys v0.26.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
20+
golang.org/x/tools v0.26.0 h1:v/60pFQmzmT9ExmjDv2gGIfi3OqfKoEP6I5+umXlbnQ=
21+
golang.org/x/tools v0.26.0/go.mod h1:TPVVj70c7JJ3WCazhD8OdXcZg/og+b9+tH/KxylGwH0=

Diff for: gofmt.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -427,9 +427,7 @@ func readFile(filename string, info fs.FileInfo, in io.Reader) ([]byte, error) {
427427
return src[:n], nil
428428
}
429429

430-
func main() { os.Exit(main1()) }
431-
432-
func main1() int {
430+
func main() {
433431
// Arbitrarily limit in-flight work to 2MiB times the number of threads.
434432
//
435433
// The actual overhead for the parse tree and output will depend on the
@@ -442,7 +440,7 @@ func main1() int {
442440
// so that it can use defer and have them
443441
// run before the exit.
444442
gofmtMain(s)
445-
return s.GetExitCode()
443+
os.Exit(s.GetExitCode())
446444
}
447445

448446
func gofmtMain(s *sequencer) {

Diff for: main_test.go

+3-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ package main
66
import (
77
"encoding/json"
88
"flag"
9-
"os"
109
"os/exec"
1110
"path/filepath"
1211
"testing"
@@ -18,9 +17,9 @@ import (
1817
)
1918

2019
func TestMain(m *testing.M) {
21-
os.Exit(testscript.RunMain(m, map[string]func() int{
22-
"gofumpt": main1,
23-
}))
20+
testscript.Main(m, map[string]func(){
21+
"gofumpt": main,
22+
})
2423
}
2524

2625
var update = flag.Bool("u", false, "update testscript output files")

Diff for: ulimit_linux_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func init() {
2727
if err := unix.Setrlimit(unix.RLIMIT_NOFILE, &rlimit); err != nil {
2828
panic(err)
2929
}
30-
os.Exit(main1())
30+
main()
3131
}
3232
}
3333

0 commit comments

Comments
 (0)