gofumpt re-formats tabs to spaces (was: New release built with go 1.19?)

[morremeyer]

I propose to make a new release built with go 1.19.

go 1.19 improved support for documentation comments a lot, see https://tip.golang.org/doc/go1.19#go-doc.
Other tools, like swagger, have started to adopt this.

The behaviour of gofumpt depends on the go version it is built with (due to the use of go/printer from go - see #244 (comment) if you want to learn more.

gofumpt is starting to become incompatible with documentation comments using those new features as it formats them in a way that breaks the use of those new features.

I'll make a PR to bump the version in the next few days.

[mvdan]

What version bump do you mean? Note that the latest version, https://github.com/mvdan/gofumpt/releases/tag/v0.4.0, was already based on (and built with) Go 1.19.

The only quirk is #244. If someone builds gofumpt with Go 1.18, its behavior changes, as we depend on the standard library's go/printer formatting behavior. We'll fix that, but it's unrelated to "bumping" the Go version.

[morremeyer]

I was looking at the go.mod go line and wrongly assumed this influenced anything.

I analyzed this further and discovered that this also happens when using gofmt (cmd/gofmt), so gofumpt is not the reason for this behaviour, it rather seems to be an issue in the code formatting that swag does or in gofmt itself.

I will continue to analyze this. If it's an issue in gofmt, I'll propose an update of that dependency one a fix has been made.

Thanks for your answer and the work on the tool in general!

[morremeyer]

The issue was with my documentation, sorry for the fuzz here. Details in swaggo/swag#1386 (comment)