Skip to content

Commit afc7a03

Browse files
committed
Update PR based on comments
1 parent 4328e90 commit afc7a03

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

doc/whatsnew/v0.12.0.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,8 @@ Other updates
100100

101101
- |Fix| Improved robustness to numerical errors in :func:`kdeplot` (:pr:`2862`).
102102

103+
- |Fix| Fixed a bug where :func:`rugplot` was ignoring expand_margins=False (:pr:`2953`).
104+
103105
- |Defaults| The `patch.facecolor` rc param is no longer set by :func:`set_palette` (or :func:`set_theme`). This should have no general effect, because the matplotlib default is now `"C0"` (:pr:`2906`).
104106

105107
- |Deps| Made `scipy` an optional dependency and added `pip install seaborn[stats]` as a method for ensuring the availability of compatible `scipy` and `statsmodels` libraries at install time. This has a few minor implications for existing code, which are explained in the Github pull request (:pr:`2398`).

tests/test_distributions.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -305,17 +305,15 @@ def test_expand_margins(self, flat_array):
305305
assert x1 == x2
306306
assert y1 + height * 2 == pytest.approx(y2)
307307

308-
def test_multiple_rugs(self, long_df):
308+
def test_multiple_rugs(self):
309309

310310
values = np.linspace(start=0, stop=1, num=5)
311-
ax = lineplot(x=values, y=values)
312-
rugplot(x=values, ax=ax)
311+
ax = rugplot(x=values)
313312
ylim = ax.get_ylim()
314313

315-
for j in range(4):
316-
rugplot(x=values, ax=ax, expand_margins=False)
314+
rugplot(x=values, ax=ax, expand_margins=False)
317315

318-
assert_array_equal(ylim, ax.get_ylim())
316+
assert ylim == ax.get_ylim()
319317

320318
def test_matplotlib_kwargs(self, flat_series):
321319

0 commit comments

Comments
 (0)