🐛 fix es/no-logical-assignment-operators autofix (fixes #57)

mysticatea · mysticatea · commit 00d738517935 · 2020-12-08T10:41:51.000+09:00
diff --git a/lib/rules/no-logical-assignment-operators.js b/lib/rules/no-logical-assignment-operators.js
@@ -31,7 +31,7 @@ module.exports = {
                     node: operatorToken,
                     messageId: "forbidden",
                     fix(fixer) {
-                        if (utils.hasSideEffect(node.left, sourceCode)) {
+                        if (node.left.type !== "Identifier") {
                             return null
                         }
                         const newOperator = node.operator.slice(-1)
diff --git a/tests/lib/rules/no-logical-assignment-operators.js b/tests/lib/rules/no-logical-assignment-operators.js
@@ -40,7 +40,7 @@ new RuleTester().run("no-logical-assignment-operators", rule, {
         },
         {
             code: "a.b ||= c",
-            output: "a.b = a.b || (c)",
+            output: null,
             errors: ["ES2021 logical assignment operators are forbidden."],
         },
         {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ module.exports = {`
`31`	`31`	`node: operatorToken,`
`32`	`32`	`messageId: "forbidden",`
`33`	`33`	`fix(fixer) {`
`34`		`- if (utils.hasSideEffect(node.left, sourceCode)) {`
	`34`	`+ if (node.left.type !== "Identifier") {`
`35`	`35`	`return null`
`36`	`36`	`}`
`37`	`37`	`const newOperator = node.operator.slice(-1)`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ new RuleTester().run("no-logical-assignment-operators", rule, {`
`40`	`40`	`},`
`41`	`41`	`{`
`42`	`42`	`code: "a.b \|\|= c",`
`43`		`- output: "a.b = a.b \|\| (c)",`
	`43`	`+ output: null,`
`44`	`44`	`errors: ["ES2021 logical assignment operators are forbidden."],`
`45`	`45`	`},`
`46`	`46`	`{`