Skip to content

Commit d38884f

Browse files
authored
Merge pull request #95 from lavcraft/fix-GAP-281
GAP-281 – Avoid using removed BuildInfoBaseTask i
2 parents ac6a4b1 + 796a24a commit d38884f

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/main/groovy/nebula/plugin/release/ReleasePlugin.groovy

+10
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ import org.gradle.api.publish.ivy.plugins.IvyPublishPlugin
3333
import org.gradle.api.publish.ivy.tasks.GenerateIvyDescriptor
3434
import org.gradle.api.publish.maven.plugins.MavenPublishPlugin
3535
import org.gradle.api.publish.maven.tasks.GenerateMavenPom
36+
import org.jfrog.gradle.plugin.artifactory.task.ArtifactoryTask
3637
import org.jfrog.gradle.plugin.artifactory.task.BuildInfoBaseTask
3738

3839
class ReleasePlugin implements Plugin<Project> {
@@ -255,12 +256,21 @@ class ReleasePlugin implements Plugin<Project> {
255256
}
256257

257258
if (isClassPresent('org.jfrog.gradle.plugin.artifactory.task.BuildInfoBaseTask')) {
259+
project.logger.warn 'Please upgrade com.jfrog.artifactory (org.jfrog.buildinfo:build-info-extractor-gradle:) to version 4.6.0 or above'
258260
project.tasks.withType(BuildInfoBaseTask) { Task task ->
259261
project.plugins.withType(JavaPlugin) {
260262
task.dependsOn(project.tasks.build)
261263
}
262264
project.rootProject.tasks.postRelease.dependsOn(task)
263265
}
266+
} else if(isClassPresent('org.jfrog.gradle.plugin.artifactory.task.ArtifactoryTask')) {
267+
// JFrog remove BuildInfoBaseTask see https://www.jfrog.com/jira/browse/GAP-281
268+
project.tasks.withType(ArtifactoryTask) { Task task ->
269+
project.plugins.withType(JavaPlugin) {
270+
task.dependsOn(project.tasks.build)
271+
}
272+
project.rootProject.tasks.postRelease.dependsOn(task)
273+
}
264274
} else {
265275
logger.info('Skipping configuration of artifactoryPublish task since it is not present')
266276
}

src/test/groovy/nebula/plugin/release/ReleasePluginOptionalDepsSpec.groovy

+2-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ class ReleasePluginOptionalDepsSpec extends ProjectSpec {
5252
Logger myLogger = Mock()
5353
ReleasePlugin.logger = myLogger
5454
ReleasePlugin.metaClass.isClassPresent = { String name ->
55-
name != 'org.jfrog.gradle.plugin.artifactory.task.BuildInfoBaseTask'
55+
name != 'org.jfrog.gradle.plugin.artifactory.task.BuildInfoBaseTask' &&
56+
name != 'org.jfrog.gradle.plugin.artifactory.task.ArtifactoryTask'
5657
}
5758

5859
when:

0 commit comments

Comments
 (0)