build: disable most implicit make rules (.SUFFIXES)

kmk3 · kmk3 · commit 331a4347f582 · 2023-06-20T06:28:21.000-03:00
To reduce unnecessary filesystem lookups. Overall, this appears to reduce the amount of implicit rule searches by ~62% for the default build and by ~96% for the "man" target (as an example): $ git checkout master >/dev/null 2>&1 $ git show --pretty='%h %ai %s' -s a8f01a3 2023-06-20 05:26:23 +0000 Merge pull request #5859 from kmk3/build-remove-retpoline $ ./configure >/dev/null $ make clean >/dev/null && make --debug=i -j 4 | grep -F 'Trying implicit' | wc -l 6798 $ make clean >/dev/null && make --debug=i -j 4 man | grep -F 'Trying implicit' | wc -l 1085 # (with this commit applied) $ make clean >/dev/null && make --debug=i -j 4 | grep -F 'Trying implicit' | wc -l 2535 $ make clean >/dev/null && make --debug=i -j 4 man | grep -F 'Trying implicit' | wc -l 42 Environment: GNU make 4.4.1-2 on Artix Linux. Commands used to search and replace: $ git ls-files -z -- '*Makefile*' | xargs -0 -I '{}' sh -c \ "printf '%s\n' \"\$(sed '1s/^/.SUFFIXES:\n/' '{}')\" >'{}'" See also commit f48886f ("build: mark most phony targets as such", 2023-02-01) / PR #5637.
diff --git a/Makefile b/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = .
 -include config.mk
 
diff --git a/src/bash_completion/Makefile b/src/bash_completion/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 .PHONY: all
 all: firejail.bash_completion
 
diff --git a/src/etc-cleanup/Makefile b/src/etc-cleanup/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fbuilder/Makefile b/src/fbuilder/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fcopy/Makefile b/src/fcopy/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fids/Makefile b/src/fids/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/firecfg/Makefile b/src/firecfg/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/firejail/Makefile b/src/firejail/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/firemon/Makefile b/src/firemon/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fldd/Makefile b/src/fldd/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnet/Makefile b/src/fnet/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnetfilter/Makefile b/src/fnetfilter/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnettrace-dns/Makefile b/src/fnettrace-dns/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnettrace-icmp/Makefile b/src/fnettrace-icmp/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnettrace-sni/Makefile b/src/fnettrace-sni/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fnettrace/Makefile b/src/fnettrace/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fsec-optimize/Makefile b/src/fsec-optimize/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fsec-print/Makefile b/src/fsec-print/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fseccomp/Makefile b/src/fseccomp/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/ftee/Makefile b/src/ftee/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/fzenity/Makefile b/src/fzenity/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/jailcheck/Makefile b/src/jailcheck/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/lib/Makefile b/src/lib/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/libpostexecseccomp/Makefile b/src/libpostexecseccomp/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/libtrace/Makefile b/src/libtrace/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/libtracelog/Makefile b/src/libtracelog/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/man/Makefile b/src/man/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 .PHONY: all
 all: firecfg.man firejail.man firejail-login.man firejail-users.man firejail-profile.man firemon.man jailcheck.man
 
diff --git a/src/profstats/Makefile b/src/profstats/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 ROOT = ../..
 -include $(ROOT)/config.mk
 
diff --git a/src/zsh_completion/Makefile b/src/zsh_completion/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 .PHONY: all
 all: _firejail
 
diff --git a/test/Makefile b/test/Makefile
@@ -1,3 +1,4 @@
+.SUFFIXES:
 TESTS=$(patsubst %/,%,$(wildcard */))
 
 .PHONY: $(TESTS)

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.SUFFIXES:`
`1`	`2`	`ROOT = .`
`2`	`3`	`-include config.mk`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.SUFFIXES:`
`1`	`2`	`.PHONY: all`
`2`	`3`	`all: firejail.bash_completion`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.SUFFIXES:`
`1`	`2`	`ROOT = ../..`
`2`	`3`	`-include $(ROOT)/config.mk`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+.SUFFIXES:`
`1`	`2`	`TESTS=$(patsubst %/,%,$(wildcard */))`
`2`	`3`
`3`	`4`	`.PHONY: $(TESTS)`