stop skipping generate if notes file missing

qrkourier · qrkourier · commit 5b5dc1fee24c · 2024-08-08T17:30:06.000-04:00
Signed-off-by: Kenneth Bingham &lt;kenneth.bingham@netfoundry.io&gt;
diff --git a/pkg/releaser/releaser.go b/pkg/releaser/releaser.go
@@ -249,7 +249,8 @@ func (r *Releaser) getReleaseNotes(chart *chart.Chart) (string, error) {
 			}
 		}
 		fmt.Printf("The release note file %q, is not present in the chart package\n", r.config.ReleaseNotesFile)
-	} else if r.config.GenerateReleaseNotes {
+	}
+	if r.config.GenerateReleaseNotes {
 		latestRelease, err := r.github.GetLatestChartRelease(context.TODO(), chart.Metadata.Name)
 		if err != nil {
 			return "", errors.Wrapf(err, "failed to get latest release for chart %s", chart.Metadata.Name)

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,8 @@ func (r Releaser) getReleaseNotes(chart chart.Chart) (string, error) {`
`249`	`249`	`}`
`250`	`250`	`}`
`251`	`251`	`fmt.Printf("The release note file %q, is not present in the chart package\n", r.config.ReleaseNotesFile)`
`252`		`- } else if r.config.GenerateReleaseNotes {`
	`252`	`+ }`
	`253`	`+ if r.config.GenerateReleaseNotes {`
`253`	`254`	`latestRelease, err := r.github.GetLatestChartRelease(context.TODO(), chart.Metadata.Name)`
`254`	`255`	`if err != nil {`
`255`	`256`	`return "", errors.Wrapf(err, "failed to get latest release for chart %s", chart.Metadata.Name)`