Skip to content

Commit e3db4f4

Browse files
committed
fixes #2343 Trim the encoding for req res tranformer interceptors
1 parent 6a0b587 commit e3db4f4

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

request-transformer/src/main/java/com/networknt/reqtrans/RequestTransformerInterceptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public void handleRequest(HttpServerExchange exchange) throws Exception {
147147
if (shouldAttachBody(exchange.getRequestHeaders())) {
148148
if(logger.isTraceEnabled()) logger.trace("shouldAttachBody is true");
149149
PooledByteBuffer[] requestData = this.getBuffer(exchange);
150-
String s = BuffersUtils.toString(requestData, encoding != null ? encoding : config.getDefaultBodyEncoding());
150+
String s = BuffersUtils.toString(requestData, encoding != null ? encoding.trim() : config.getDefaultBodyEncoding());
151151
// Transform the request body with the rule engine.
152152
if(logger.isDebugEnabled()) logger.debug("original request body = {}", s);
153153
objMap.put("requestBody", s);

response-transformer/src/main/java/com/networknt/restrans/ResponseTransformerInterceptor.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void handleRequest(HttpServerExchange exchange) throws Exception {
109109
if(match.isPresent()) {
110110
String encoding = StringUtils.getSecondPart(match.get());
111111
if(encoding != null && logger.isTraceEnabled()) logger.trace("Customized encoding {} found in the prefix {} for requestPath {}", encoding, match.get(), requestPath);
112-
String responseBody = BuffersUtils.toString(getBuffer(exchange), encoding != null ? encoding : config.getDefaultBodyEncoding());
112+
String responseBody = BuffersUtils.toString(getBuffer(exchange), encoding != null ? encoding.trim() : config.getDefaultBodyEncoding());
113113
if (logger.isTraceEnabled())
114114
logger.trace("original response body = {}", responseBody);
115115

utility/src/test/java/com/networknt/utility/StringUtilsTest.java

+6
Original file line numberDiff line numberDiff line change
@@ -95,5 +95,11 @@ public void testGetSecondPart() {
9595

9696
result = StringUtils.getSecondPart("Multiple Words Here");
9797
Assert.assertEquals("Words Here", result);
98+
99+
result = StringUtils.getSecondPart("Hello World ");
100+
Assert.assertEquals("World ", result);
101+
102+
result = StringUtils.getSecondPart("Hello World ");
103+
Assert.assertEquals(" World ", result);
98104
}
99105
}

0 commit comments

Comments
 (0)