Merge pull request #6458 from nextcloud-libraries/fix/NcSelect--value-modelValue

susnux · web-flow · commit bb4c9f43e287 · 2025-01-26T12:36:48.000+01:00
[next] fix(NcSelect): `required` doesn't work
diff --git a/src/components/NcSelect/NcSelect.vue b/src/components/NcSelect/NcSelect.vue
@@ -991,7 +991,7 @@ export default {
 				return null
 			}
 			// The <input> itself does not have any value so we set the `required` attribute conditionally
-			return this.value === null || (Array.isArray(this.value) && this.value.length === 0)
+			return this.modelValue === null || (Array.isArray(this.modelValue) && this.modelValue.length === 0)
 		},
 
 		localCalculatePosition() {

Original file line number	Diff line number	Diff line change
`@@ -991,7 +991,7 @@ export default {`
`991`	`991`	`return null`
`992`	`992`	`}`
`993`	`993`	// The <input> itself does not have any value so we set the `required` attribute conditionally
`994`		`- return this.value === null \|\| (Array.isArray(this.value) && this.value.length === 0)`
	`994`	`+ return this.modelValue === null \|\| (Array.isArray(this.modelValue) && this.modelValue.length === 0)`
`995`	`995`	`},`
`996`	`996`
`997`	`997`	`localCalculatePosition() {`