Merge pull request #31 from nextcloud/enh/break-promoted-properties-on-multiline

feat: Add rule for having one promoted property per line in constructor

Author: ChristophWurst

CHANGELOG.md

@@ -1,6 +1,12 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## 1.2.4 - TBA
+
+### Changed
+* `trailing_comma_in_multiline`: Add a trailing comma to multline function parameters
+* `MultilinePromotedPropertiesFixer`: Break promoted properties on multiple lines
+
 ## 1.2.3 - 2024-08-23
 ### Changed
 * `cast_spaces`: No space between cast and variable

composer.json

@@ -4,7 +4,8 @@
     "type": "library",
     "require": {
         "php": "^7.3|^8.0",
-        "php-cs-fixer/shim": "^3.17"
+        "php-cs-fixer/shim": "^3.17",
+        "kubawerlos/php-cs-fixer-custom-fixers": "^3.22"
     },
     "license": "MIT",
     "authors": [

src/Config.php

@@ -5,11 +5,13 @@
 namespace Nextcloud\CodingStandard;
 
 use PhpCsFixer\Config as Base;
+use PhpCsFixerCustomFixers;
 
 class Config extends Base {
 	public function __construct($name = 'default') {
 		parent::__construct($name);
 		$this->setIndent("\t");
+		$this->registerCustomFixers(new PhpCsFixerCustomFixers\Fixers());
 	}
 
 	public function getRules() : array {
@@ -67,11 +69,13 @@ public function getRules() : array {
 			'single_line_after_imports' => true,
 			'single_quote' => ['strings_containing_single_quote_chars' => false],
 			'switch_case_space' => true,
+			'trailing_comma_in_multiline' => ['elements' => ['parameters']],
 			'types_spaces' => ['space' => 'none', 'space_multiple_catch' => 'none'],
 			'visibility_required' => [
 				'elements' => ['property', 'method', 'const']
 			],
 			'yoda_style' => ['equal' => false, 'identical' => false, 'less_and_greater' => false],
+			PhpCsFixerCustomFixers\Fixer\MultilinePromotedPropertiesFixer::name() => true,
 		];
 	}
 }