fix: don't return 412 for if-none-match failures #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes nodejs/build#4030 Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/build-4030
branch
from
93b4978 to
9fbccb3
Compare
ovflowd
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nodejs/build#4030
Misinterpretation of the docs, precondition failures due to
if-none-matchreturn a 412 for unsafe http methods (aka those that modify things on the sever-side). For safe methods (GET, HEAD), they return a 304.https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-None-Match