Skip to content

Commit 106dd1e

Browse files
rneatherwayrefack
authored andcommitted
lib: fix a few minor issues flagged by lgtm
* Confusing (but correct) regex using `A-z` character range by accident * Add the status argument to afterShutdown PR-URL: #25873 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
1 parent 91adbe1 commit 106dd1e

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/internal/http2/core.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1515,7 +1515,8 @@ function streamOnPause() {
15151515
this[kHandle].readStop();
15161516
}
15171517

1518-
function afterShutdown() {
1518+
function afterShutdown(status) {
1519+
// Currently this status value is unused
15191520
this.callback();
15201521
const stream = this.handle[kOwner];
15211522
if (stream)

tools/cpplint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ def GetNonHeaderExtensions():
636636

637637
_RIGHT_LEANING_POINTER_PATTERN = re.compile(r'[^=|(,\s><);&?:}]'
638638
r'(?<!(sizeof|return))'
639-
r'\s\*[a-zA-z_][0-9a-zA-z_]*')
639+
r'\s\*[a-zA-Z_][0-9a-zA-Z_]*')
640640

641641
_regexp_compile_cache = {}
642642

0 commit comments

Comments
 (0)